RESOLVED FIXED Bug 88524
check-webkit-style needs to be taught about <public/Foo.h> 
https://bugs.webkit.org/show_bug.cgi?id=88524
Summary check-webkit-style needs to be taught about <public/Foo.h>
Kinuko Yasuda
Reported 2012-06-07 04:37:17 PDT
Currently check-webkit-style considers any headers included with <> (i.e. is_system==True) as non-primary headers, but some platform implementation includes its primary header placed under Platform/.../public with <>. check-webkit-style warns include_order for those files. Examples: Source/WebCore/platform/chromium/support/WebHTTPBody.cpp Source/WebCore/platform/chromium/support/WebHTTPLoadInfo.cpp Source/WebCore/platform/chromium/support/WebURL.cpp Source/WebCore/platform/chromium/support/WebURLError.cpp Source/WebCore/platform/chromium/support/WebURLRequest.cpp Source/WebCore/platform/chromium/support/WebURLResponse.cpp Running check-webkit-style on any of these files generates include_order error: Source/WebCore/platform/chromium/support/WebHTTPBody.cpp:33: Alphabetical sorting problem. [build/include_order] [4]
Attachments
Patch (4.47 KB, patch)
2012-06-07 04:41 PDT, Kinuko Yasuda 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kinuko Yasuda
Comment 1 2012-06-07 04:41:04 PDT
Created attachment 146253 [details] Patch
Kinuko Yasuda
Comment 2 2012-06-07 21:24:41 PDT
Committed r119794: <http://trac.webkit.org/changeset/119794>
Note You need to log in before you can comment on or make changes to this bug.