Bug 88511 - [GTK] deviceScaleFactor setting is not honored
Summary: [GTK] deviceScaleFactor setting is not honored
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-07 01:18 PDT by Simon Pena
Modified: 2012-06-07 08:24 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.59 KB, patch)
2012-06-07 04:07 PDT, Simon Pena
no flags Details | Formatted Diff | Diff
Patch (1.51 KB, patch)
2012-06-07 07:43 PDT, Simon Pena
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Pena 2012-06-07 01:18:19 PDT
There's currently no way to update the deviceScaleFactor using the internal settings in the GTK port.
Comment 1 Simon Pena 2012-06-07 02:31:48 PDT
Besides the WebKitWebSettings not being connected, the GraphicsContext
is currently ignoring the deviceScaleFactor setting.

This was fixed in Chromium in bug #88136. The test

LayoutTests/fast/hidpi/device-scale-factor-paint.html

was added there, and is currently failing in the GTK port.
Comment 2 Simon Pena 2012-06-07 03:49:43 PDT
I don't think we need to update the WebKitWebSettings, but simply make the GraphicContext honor the device scale factor property when drawing the WebView, as the Chromium port does in bug #88136.
Comment 3 Simon Pena 2012-06-07 04:07:46 PDT
Created attachment 146250 [details]
Patch
Comment 4 Simon Pena 2012-06-07 04:18:06 PDT
CCing Álex and Martin since they're working around this part
Comment 5 Gustavo Noronha (kov) 2012-06-07 07:30:42 PDT
Comment on attachment 146250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146250&action=review

> Source/WebKit/gtk/ChangeLog:9
> +        method of the ChromeClientGTk, since it was previously

The t in Gtk is upper. I'd remove everything after the comma =).
Comment 6 Simon Pena 2012-06-07 07:43:56 PDT
Created attachment 146289 [details]
Patch
Comment 7 WebKit Review Bot 2012-06-07 08:24:47 PDT
Comment on attachment 146289 [details]
Patch

Clearing flags on attachment: 146289

Committed r119726: <http://trac.webkit.org/changeset/119726>
Comment 8 WebKit Review Bot 2012-06-07 08:24:51 PDT
All reviewed patches have been landed.  Closing bug.