NEW88507
[Refactoring] requestAnimationFrame() can be Supplement 
https://bugs.webkit.org/show_bug.cgi?id=88507
Summary [Refactoring] requestAnimationFrame() can be Supplement
Hajime Morrita
Reported 2012-06-07 00:27:14 PDT
requestAnimationFrame() is basically implemented in ScriptedAnimationController, which is a perfect candidate of Supplement<ScriptExceptionContext>.
Attachments
Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-06-07 11:45:26 PDT
Could you explain what this means?
Adam Barth
Comment 2 2012-06-07 16:59:34 PDT
I think what Morrita means is that we can use the Supplement pattern to remove all the ENABLE(REQUEST_ANIMATION_FRAME) ifdefs and m_scriptedAnimationController mentions from Document.cpp. The idea is that ScriptedAnimationController would subclass Supplement<ScriptExceptionContext> and folks that wanted to talk with the controller would ask for ScriptedAnimationController::from(document).
Hajime Morrita
Comment 3 2012-06-07 17:34:54 PDT
Oops. I'm sorry for the short of explanation. What Adam says is right.
Note You need to log in before you can comment on or make changes to this bug.