Bug 88505 – REGRESSION(r119683): it broke webkit-unit-test WebLayerTreeViewThreadedTest.InstrumentationCallbacks on mac (Requested by loislo on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/119683 broke the build:
it broke webkit-unit-test WebLayerTreeViewThreadedTest.InstrumentationCallbacks on mac (Requested by loislo on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 146202 [details]
ROLLOUT of r119683

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Ilya Tikhonovsky]

Comment on attachment 146202 [details]
ROLLOUT of r119683

Clearing flags on attachment: 146202

Committed r119685: <http://trac.webkit.org/changeset/119685>

[Ilya Tikhonovsky]

All reviewed patches have been landed.  Closing bug.

[Ilya Tikhonovsky]

the log:

[----------] 1 test from WebLayerTreeViewThreadedTest
[ RUN      ] WebLayerTreeViewThreadedTest.InstrumentationCallbacks
unknown file: Failure

Unexpected mock function call - returning directly.
    Function call: willBeginFrame()
Google Mock tried the following 1 expectation, but it didn't match:

/Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/tests/WebLayerTreeViewTest.cpp:212: EXPECT_CALL(m_client, willBeginFrame())...
         Expected: the expectation is active
           Actual: it is retired
         Expected: to be called once
           Actual: called once - saturated and retired
unknown file: Failure

Unexpected mock function call - returning directly.
    Function call: willCommit()
Google Mock tried the following 1 expectation, but it didn't match:

/Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/tests/WebLayerTreeViewTest.cpp:213: EXPECT_CALL(m_client, willCommit())...
         Expected: the expectation is active
           Actual: it is retired
         Expected: to be called once
           Actual: called once - saturated and retired
unknown file: Failure

Unexpected mock function call - returning directly.
    Function call: didCommit()
Google Mock tried the following 1 expectation, but it didn't match:

/Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/tests/WebLayerTreeViewTest.cpp:214: EXPECT_CALL(m_client, didCommit())...
         Expected: the expectation is active
           Actual: it is retired
         Expected: to be called once
           Actual: called once - saturated and retired
/Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/tests/WebLayerTreeViewTest.cpp:215: Failure
Mock function called more times than expected - returning directly.
    Function call: didBeginFrame()
         Expected: to be called once
           Actual: called twice - over-saturated and active
[  FAILED  ] WebLayerTreeViewThreadedTest.InstrumentationCallbacks (1 ms)
[----------] 1 test from WebLayerTreeViewThreadedTest (1 ms total)