Bug 88491 - [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
Summary: [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-06 21:09 PDT by Dongwoo Joshua Im (dwim)
Modified: 2012-06-07 22:37 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.66 KB, patch)
2012-06-06 21:15 PDT, Dongwoo Joshua Im (dwim)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dongwoo Joshua Im (dwim) 2012-06-06 21:09:15 PDT
WebAudio feature has been implemented on EFL port.

DRT should enable WebAudio when WebAudio feature is enabled,
so that the WebAudio feature could be tested by the Layouttest.
Comment 1 Dongwoo Joshua Im (dwim) 2012-06-06 21:15:59 PDT
Created attachment 146188 [details]
Patch
Comment 2 Gyuyoung Kim 2012-06-06 21:17:09 PDT
Comment on attachment 146188 [details]
Patch

Looks fine.
Comment 3 WebKit Review Bot 2012-06-07 18:33:42 PDT
Comment on attachment 146188 [details]
Patch

Clearing flags on attachment: 146188

Committed r119780: <http://trac.webkit.org/changeset/119780>
Comment 4 WebKit Review Bot 2012-06-07 18:33:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-06-07 20:53:30 PDT
Comment on attachment 146188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146188&action=review

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:720
> +    else if (equals(key, "WebKitWebAudioEnabled"))
> +        ewk_view_setting_web_audio_set(browser->mainView(), toBool(value));

You probably need to reset this to a sane default in DumpRenderTreeChrome::resetDefaultsToConsistentValues().
Comment 6 Dongwoo Joshua Im (dwim) 2012-06-07 22:37:29 PDT
(In reply to comment #5)
> (From update of attachment 146188 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146188&action=review
> 
> > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:720
> > +    else if (equals(key, "WebKitWebAudioEnabled"))
> > +        ewk_view_setting_web_audio_set(browser->mainView(), toBool(value));
> 
> You probably need to reset this to a sane default in DumpRenderTreeChrome::resetDefaultsToConsistentValues().

I see what you are saying.
I will file that bug now.

And, I think I need to fix the test cases.
I will file that also.