Bug 88491 – [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Dongwoo Joshua Im (dwim)]

WebAudio feature has been implemented on EFL port.

DRT should enable WebAudio when WebAudio feature is enabled,
so that the WebAudio feature could be tested by the Layouttest.

[Dongwoo Joshua Im (dwim)]

Created attachment 146188 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 146188 [details]
Patch

Looks fine.

[WebKit Review Bot]

Comment on attachment 146188 [details]
Patch

Clearing flags on attachment: 146188

Committed r119780: <http://trac.webkit.org/changeset/119780>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 146188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146188&action=review

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:720
> +    else if (equals(key, "WebKitWebAudioEnabled"))
> +        ewk_view_setting_web_audio_set(browser->mainView(), toBool(value));

You probably need to reset this to a sane default in DumpRenderTreeChrome::resetDefaultsToConsistentValues().

[Dongwoo Joshua Im (dwim)]

(In reply to comment #5)
> (From update of attachment 146188 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146188&action=review
> 
> > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:720
> > +    else if (equals(key, "WebKitWebAudioEnabled"))
> > +        ewk_view_setting_web_audio_set(browser->mainView(), toBool(value));
> 
> You probably need to reset this to a sane default in DumpRenderTreeChrome::resetDefaultsToConsistentValues().

I see what you are saying.
I will file that bug now.

And, I think I need to fix the test cases.
I will file that also.