Bug 88477 - PredictedType should be called SpeculatedType
Summary: PredictedType should be called SpeculatedType
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-06 18:13 PDT by Filip Pizlo
Modified: 2012-06-06 18:36 PDT (History)
2 users (show)

See Also:


Attachments
the patch (391.99 KB, patch)
2012-06-06 18:15 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
improved patch (352.80 KB, patch)
2012-06-06 18:20 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-06-06 18:13:28 PDT
Justification: it's used for more than just predictions.  It's also used for type proofs in the CFA and DFG backend.

The only thing in common between all uses of the types in PredictedType is that they are all used for creating and optimizing speculations, even though sometimes they mean predictions and other times they mean proofs.

Already rubber stamped by Gavin Barraclough.
Comment 1 Filip Pizlo 2012-06-06 18:15:10 PDT
Created attachment 146169 [details]
the patch

Putting up for EWS.
Comment 2 WebKit Review Bot 2012-06-06 18:18:29 PDT
Attachment 146169 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1
Source/JavaScriptCore/bytecode/LazyOperandValueProfile.h:177:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2012-06-06 18:20:09 PDT
Created attachment 146170 [details]
improved patch

Found places where my rename was a bit overzealous.
Comment 4 WebKit Review Bot 2012-06-06 18:22:11 PDT
Attachment 146170 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1
Source/JavaScriptCore/bytecode/LazyOperandValueProfile.h:177:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Filip Pizlo 2012-06-06 18:36:38 PDT
Landed in http://trac.webkit.org/changeset/119660