Bug 88465 - Don't rely on weak pointers for eager CodeBlock finalization
Summary: Don't rely on weak pointers for eager CodeBlock finalization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-06 15:35 PDT by Geoffrey Garen
Modified: 2012-06-08 11:17 PDT (History)
3 users (show)

See Also:


Attachments
Patch (23.46 KB, patch)
2012-06-06 17:27 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (23.46 KB, patch)
2012-06-07 11:12 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (24.02 KB, patch)
2012-06-07 11:51 PDT, Geoffrey Garen
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2012-06-06 15:35:47 PDT
Don't rely on weak pointers for eager CodeBlock finalization
Comment 1 Geoffrey Garen 2012-06-06 17:27:16 PDT
Created attachment 146157 [details]
Patch
Comment 2 Build Bot 2012-06-06 18:23:08 PDT
Comment on attachment 146157 [details]
Patch

Attachment 146157 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12897991
Comment 3 Early Warning System Bot 2012-06-06 18:30:16 PDT
Comment on attachment 146157 [details]
Patch

Attachment 146157 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12917030
Comment 4 Early Warning System Bot 2012-06-06 18:36:35 PDT
Comment on attachment 146157 [details]
Patch

Attachment 146157 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12909127
Comment 5 Build Bot 2012-06-06 18:52:01 PDT
Comment on attachment 146157 [details]
Patch

Attachment 146157 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12900995
Comment 6 Gyuyoung Kim 2012-06-06 19:47:35 PDT
Comment on attachment 146157 [details]
Patch

Attachment 146157 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12905990
Comment 7 Geoffrey Garen 2012-06-07 11:12:50 PDT
Created attachment 146331 [details]
Patch
Comment 8 Build Bot 2012-06-07 11:46:25 PDT
Comment on attachment 146331 [details]
Patch

Attachment 146331 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12922225
Comment 9 Geoffrey Garen 2012-06-07 11:51:49 PDT
Created attachment 146345 [details]
Patch
Comment 10 Geoffrey Garen 2012-06-08 11:17:22 PDT
Committed r119844: <http://trac.webkit.org/changeset/119844>