Bug 88460 - [chromium] Clean up GraphicsContext3D implementation
Summary: [chromium] Clean up GraphicsContext3D implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-06 15:08 PDT by James Robinson
Modified: 2012-06-06 15:59 PDT (History)
4 users (show)

See Also:


Attachments
Patch (119.93 KB, patch)
2012-06-06 15:21 PDT, James Robinson
kbr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-06-06 15:08:01 PDT
[chromium] Clean up GraphicsContext3D implementation
Comment 1 James Robinson 2012-06-06 15:21:06 PDT
Created attachment 146123 [details]
Patch
Comment 2 James Robinson 2012-06-06 15:23:30 PDT
Here's some very overdue cleanup.  Diffstat:

 Source/WebKit/chromium/ChangeLog                   |  128 ++
 Source/WebKit/chromium/WebKit.gyp                  |    1 +
 .../WebKit/chromium/src/Extensions3DChromium.cpp   |   56 +-
 .../chromium/src/GraphicsContext3DChromium.cpp     | 1404 +++++---------------
 .../chromium/src/GraphicsContext3DPrivate.cpp      |  379 ++++++
 .../WebKit/chromium/src/GraphicsContext3DPrivate.h |  247 +----
 6 files changed, 855 insertions(+), 1360 deletions(-)


To review, I'd recommend looking at just the right hand side - the diff isn't all that illuminating.

I plan to move the implemenetations into Source/WebCore/platform/chromium/support/ as a followup, but would rather do code changes and file moves in different patches.
Comment 3 Kenneth Russell 2012-06-06 15:37:13 PDT
Comment on attachment 146123 [details]
Patch

Thanks for doing this and deleting so much boilerplate code. Looks great. r=me
Comment 4 James Robinson 2012-06-06 15:58:39 PDT
Thanks for the fast review.  webkit_unit_tests, layout tests, and gpu_tests are all happy with this patch on my box.
Comment 5 James Robinson 2012-06-06 15:59:40 PDT
Committed r119631: <http://trac.webkit.org/changeset/119631>