RESOLVED FIXED Bug 88460
[chromium] Clean up GraphicsContext3D implementation 
https://bugs.webkit.org/show_bug.cgi?id=88460
Summary [chromium] Clean up GraphicsContext3D implementation
James Robinson
Reported 2012-06-06 15:08:01 PDT
[chromium] Clean up GraphicsContext3D implementation
Attachments
Patch (119.93 KB, patch)
2012-06-06 15:21 PDT, James Robinson 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-06-06 15:21:06 PDT
Created attachment 146123 [details] Patch
James Robinson
Comment 2 2012-06-06 15:23:30 PDT
Here's some very overdue cleanup. Diffstat: Source/WebKit/chromium/ChangeLog | 128 ++ Source/WebKit/chromium/WebKit.gyp | 1 + .../WebKit/chromium/src/Extensions3DChromium.cpp | 56 +- .../chromium/src/GraphicsContext3DChromium.cpp | 1404 +++++--------------- .../chromium/src/GraphicsContext3DPrivate.cpp | 379 ++++++ .../WebKit/chromium/src/GraphicsContext3DPrivate.h | 247 +---- 6 files changed, 855 insertions(+), 1360 deletions(-) To review, I'd recommend looking at just the right hand side - the diff isn't all that illuminating. I plan to move the implemenetations into Source/WebCore/platform/chromium/support/ as a followup, but would rather do code changes and file moves in different patches.
Kenneth Russell
Comment 3 2012-06-06 15:37:13 PDT
Comment on attachment 146123 [details] Patch Thanks for doing this and deleting so much boilerplate code. Looks great. r=me
James Robinson
Comment 4 2012-06-06 15:58:39 PDT
Thanks for the fast review. webkit_unit_tests, layout tests, and gpu_tests are all happy with this patch on my box.
James Robinson
Comment 5 2012-06-06 15:59:40 PDT
Committed r119631: <http://trac.webkit.org/changeset/119631>
Note You need to log in before you can comment on or make changes to this bug.