Bug 88459 - IndexedDB: Error codes, phase one
Summary: IndexedDB: Error codes, phase one
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alec Flett
URL:
Keywords: WebExposed
Depends on:
Blocks: 85513
  Show dependency treegraph
 
Reported: 2012-06-06 14:51 PDT by Alec Flett
Modified: 2012-06-08 14:58 PDT (History)
6 users (show)

See Also:


Attachments
Patch (45.42 KB, patch)
2012-06-06 14:56 PDT, Alec Flett
no flags Details | Formatted Diff | Diff
Patch (45.34 KB, patch)
2012-06-07 09:59 PDT, Alec Flett
no flags Details | Formatted Diff | Diff
Patch (45.34 KB, patch)
2012-06-07 10:41 PDT, Alec Flett
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cq-02 (824.18 KB, application/zip)
2012-06-07 12:35 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Flett 2012-06-06 14:51:55 PDT
IndexedDB: Error codes, phase one
Comment 1 Alec Flett 2012-06-06 14:56:58 PDT
Created attachment 146118 [details]
Patch
Comment 2 Alec Flett 2012-06-06 15:12:57 PDT
jsbell@ - quick sanity check? ChangeLog explains the details.
Comment 3 WebKit Review Bot 2012-06-06 23:33:14 PDT
Comment on attachment 146118 [details]
Patch

Attachment 146118 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12922040
Comment 4 Alec Flett 2012-06-07 09:59:35 PDT
Created attachment 146313 [details]
Patch
Comment 5 Joshua Bell 2012-06-07 10:27:27 PDT
Comment on attachment 146313 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146313&action=review

lgtm

> Source/WebCore/Modules/indexeddb/IDBCursor.cpp:166
> +        // FIXME: Can this happen? should this be an ASSERT?

Agreed, this should be an ASSERT now. I think the m_gotValue check predates this and covers this case.

> Source/WebCore/Modules/indexeddb/IDBCursor.cpp:200
> +        // FIXME: Can this happen? should this be an ASSERT?

Ditto.

> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:189
> +    ASSERT(transactionPtr->mode() == IDBTransaction::VERSION_CHANGE);

Not relevant to this CL, but nice to have.
Comment 6 Alec Flett 2012-06-07 10:41:45 PDT
Created attachment 146320 [details]
Patch
Comment 7 Alec Flett 2012-06-07 10:42:30 PDT
tony@ - r? cq?
Comment 8 WebKit Review Bot 2012-06-07 12:35:31 PDT
Comment on attachment 146320 [details]
Patch

Rejecting attachment 146320 [details] from commit-queue.

New failing tests:
fast/table/multiple-captions-display.xhtml
Full output: http://queues.webkit.org/results/12909372
Comment 9 WebKit Review Bot 2012-06-07 12:35:35 PDT
Created attachment 146360 [details]
Archive of layout-test-results from ec2-cq-02

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 10 Alec Flett 2012-06-07 13:11:40 PDT
Comment on attachment 146320 [details]
Patch

argh, that has nothing to do with this patch. tony@, can we retry that? cq?
Comment 11 WebKit Review Bot 2012-06-07 14:11:55 PDT
Comment on attachment 146320 [details]
Patch

Clearing flags on attachment: 146320

Committed r119751: <http://trac.webkit.org/changeset/119751>
Comment 12 WebKit Review Bot 2012-06-07 14:12:02 PDT
All reviewed patches have been landed.  Closing bug.