IndexedDB: Error codes, phase one
Created attachment 146118 [details] Patch
jsbell@ - quick sanity check? ChangeLog explains the details.
Comment on attachment 146118 [details] Patch Attachment 146118 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12922040
Created attachment 146313 [details] Patch
Comment on attachment 146313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146313&action=review lgtm > Source/WebCore/Modules/indexeddb/IDBCursor.cpp:166 > + // FIXME: Can this happen? should this be an ASSERT? Agreed, this should be an ASSERT now. I think the m_gotValue check predates this and covers this case. > Source/WebCore/Modules/indexeddb/IDBCursor.cpp:200 > + // FIXME: Can this happen? should this be an ASSERT? Ditto. > Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:189 > + ASSERT(transactionPtr->mode() == IDBTransaction::VERSION_CHANGE); Not relevant to this CL, but nice to have.
Created attachment 146320 [details] Patch
tony@ - r? cq?
Comment on attachment 146320 [details] Patch Rejecting attachment 146320 [details] from commit-queue. New failing tests: fast/table/multiple-captions-display.xhtml Full output: http://queues.webkit.org/results/12909372
Created attachment 146360 [details] Archive of layout-test-results from ec2-cq-02 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 146320 [details] Patch argh, that has nothing to do with this patch. tony@, can we retry that? cq?
Comment on attachment 146320 [details] Patch Clearing flags on attachment: 146320 Committed r119751: <http://trac.webkit.org/changeset/119751>
All reviewed patches have been landed. Closing bug.