Bug 88454 – Use enclosingIntRect instead of pixelSnappedIntRect in RenderFileUploadControl

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Levi Weintraub]

This avoids the regression of clipping the top of the upload button at 1x zooming when the control is positioned at an offset that rounds up that happened with sub-pixel layout.

[Levi Weintraub]

Created attachment 146110 [details]
Patch

[Kent Tamura]

Comment on attachment 146110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146110&action=review

> LayoutTests/platform/gtk/TestExpectations:311
> -BUGWK60318 : fast/sub-pixel = FAIL
> -BUGWK60318 : fast/sub-pixel/float-containing-block-with-margin.html = PASS
> -BUGWK60318 : fast/sub-pixel/float-with-right-margin-zoom.html = PASS
> -BUGWK60318 : fast/sub-pixel/float-wrap-with-subpixel-top.html = PASS
> -BUGWK60318 : fast/sub-pixel/inline-block-with-margin.html = PASS
> +BUGWK85532 : fast/sub-pixel = FAIL
> +BUGWK85532 : fast/sub-pixel/float-containing-block-with-margin.html = PASS
> +BUGWK85532 : fast/sub-pixel/float-with-right-margin-zoom.html = PASS
> +BUGWK85532 : fast/sub-pixel/float-wrap-with-subpixel-top.html = PASS
> +BUGWK85532 : fast/sub-pixel/inline-block-with-margin.html = PASS

Why did you changed the bug number?

[Levi Weintraub]

(In reply to comment #2)
> (From update of attachment 146110 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146110&action=review
> 
> > LayoutTests/platform/gtk/TestExpectations:311
> > -BUGWK60318 : fast/sub-pixel = FAIL
> > -BUGWK60318 : fast/sub-pixel/float-containing-block-with-margin.html = PASS
> > -BUGWK60318 : fast/sub-pixel/float-with-right-margin-zoom.html = PASS
> > -BUGWK60318 : fast/sub-pixel/float-wrap-with-subpixel-top.html = PASS
> > -BUGWK60318 : fast/sub-pixel/inline-block-with-margin.html = PASS
> > +BUGWK85532 : fast/sub-pixel = FAIL
> > +BUGWK85532 : fast/sub-pixel/float-containing-block-with-margin.html = PASS
> > +BUGWK85532 : fast/sub-pixel/float-with-right-margin-zoom.html = PASS
> > +BUGWK85532 : fast/sub-pixel/float-wrap-with-subpixel-top.html = PASS
> > +BUGWK85532 : fast/sub-pixel/inline-block-with-margin.html = PASS
> 
> Why did you changed the bug number?

Sorry, I forgot to comment on that in the changelog. 60318 is resolved. Bug 85532 tracks enabling it on all platforms. I'll add a comment to the Changelog before landing.

Thanks for the review!

[Levi Weintraub]

Committed r119659: <http://trac.webkit.org/changeset/119659>