Bug 88454 - Use enclosingIntRect instead of pixelSnappedIntRect in RenderFileUploadControl
Summary: Use enclosingIntRect instead of pixelSnappedIntRect in RenderFileUploadControl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-06 14:25 PDT by Levi Weintraub
Modified: 2012-06-07 13:01 PDT (History)
6 users (show)

See Also:


Attachments
Patch (25.37 KB, patch)
2012-06-06 14:32 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-06-06 14:25:16 PDT
This avoids the regression of clipping the top of the upload button at 1x zooming when the control is positioned at an offset that rounds up that happened with sub-pixel layout.
Comment 1 Levi Weintraub 2012-06-06 14:32:38 PDT
Created attachment 146110 [details]
Patch
Comment 2 Kent Tamura 2012-06-06 15:27:19 PDT
Comment on attachment 146110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146110&action=review

> LayoutTests/platform/gtk/TestExpectations:311
> -BUGWK60318 : fast/sub-pixel = FAIL
> -BUGWK60318 : fast/sub-pixel/float-containing-block-with-margin.html = PASS
> -BUGWK60318 : fast/sub-pixel/float-with-right-margin-zoom.html = PASS
> -BUGWK60318 : fast/sub-pixel/float-wrap-with-subpixel-top.html = PASS
> -BUGWK60318 : fast/sub-pixel/inline-block-with-margin.html = PASS
> +BUGWK85532 : fast/sub-pixel = FAIL
> +BUGWK85532 : fast/sub-pixel/float-containing-block-with-margin.html = PASS
> +BUGWK85532 : fast/sub-pixel/float-with-right-margin-zoom.html = PASS
> +BUGWK85532 : fast/sub-pixel/float-wrap-with-subpixel-top.html = PASS
> +BUGWK85532 : fast/sub-pixel/inline-block-with-margin.html = PASS

Why did you changed the bug number?
Comment 3 Levi Weintraub 2012-06-06 15:29:14 PDT
(In reply to comment #2)
> (From update of attachment 146110 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146110&action=review
> 
> > LayoutTests/platform/gtk/TestExpectations:311
> > -BUGWK60318 : fast/sub-pixel = FAIL
> > -BUGWK60318 : fast/sub-pixel/float-containing-block-with-margin.html = PASS
> > -BUGWK60318 : fast/sub-pixel/float-with-right-margin-zoom.html = PASS
> > -BUGWK60318 : fast/sub-pixel/float-wrap-with-subpixel-top.html = PASS
> > -BUGWK60318 : fast/sub-pixel/inline-block-with-margin.html = PASS
> > +BUGWK85532 : fast/sub-pixel = FAIL
> > +BUGWK85532 : fast/sub-pixel/float-containing-block-with-margin.html = PASS
> > +BUGWK85532 : fast/sub-pixel/float-with-right-margin-zoom.html = PASS
> > +BUGWK85532 : fast/sub-pixel/float-wrap-with-subpixel-top.html = PASS
> > +BUGWK85532 : fast/sub-pixel/inline-block-with-margin.html = PASS
> 
> Why did you changed the bug number?

Sorry, I forgot to comment on that in the changelog. 60318 is resolved. Bug 85532 tracks enabling it on all platforms. I'll add a comment to the Changelog before landing.

Thanks for the review!
Comment 4 Levi Weintraub 2012-06-06 18:28:56 PDT
Committed r119659: <http://trac.webkit.org/changeset/119659>