Bug 88447 - Teach git about localizable *.strings files
Summary: Teach git about localizable *.strings files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-06 13:12 PDT by David Kilzer (:ddkilzer)
Modified: 2012-06-06 14:26 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (1.20 KB, patch)
2012-06-06 13:13 PDT, David Kilzer (:ddkilzer) 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2012-06-06 13:12:58 PDT 
Teach git about localizable *.strings files
Comment 1 David Kilzer (:ddkilzer) 2012-06-06 13:13:58 PDT 
Created attachment 146094 [details]
Patch v1
Comment 2 WebKit Review Bot 2012-06-06 13:15:32 PDT 
Attachment 146094 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'.gitattributes', u'ChangeLog']" exit_code: 1
ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2012-06-06 14:03:42 PDT 
Comment on attachment 146094 [details]
Patch v1

Love it!

Will this have any effect (good or bad) for generating patches containing changes to these files?
Comment 4 David Kilzer (:ddkilzer) 2012-06-06 14:16:11 PDT 
(In reply to comment #3)
> (From update of attachment 146094 [details])
> Love it!
> 
> Will this have any effect (good or bad) for generating patches containing changes to these files?

It will have the effect of creating a real diff for *.strings files, but developers will have to run the git-config command in order to get the nicer diffs (as was necessary with the ObjC changes).

Thanks Adam!
Comment 5 David Kilzer (:ddkilzer) 2012-06-06 14:20:13 PDT 
Committed r119619: <http://trac.webkit.org/changeset/119619>
Comment 6 Adam Roben (:aroben) 2012-06-06 14:26:19 PDT 
(In reply to comment #4)
> It will have the effect of creating a real diff for *.strings files

But will someone else be able to apply that diff to their own tree?