Bug 88443 - Change default for flex-grow back to 0
Summary: Change default for flex-grow back to 0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks: 62048 88390
  Show dependency treegraph
 
Reported: 2012-06-06 12:22 PDT by Ojan Vafai
Modified: 2012-06-12 12:06 PDT (History)
3 users (show)

See Also:


Attachments
Patch (13.75 KB, patch)
2012-06-06 12:22 PDT, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch for landing (13.73 KB, patch)
2012-06-06 12:43 PDT, Ojan Vafai
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cq-03 (710.77 KB, application/zip)
2012-06-06 21:22 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-06-06 12:22:06 PDT
Change default for flex-grow back to 0
Comment 1 Ojan Vafai 2012-06-06 12:22:43 PDT
Created attachment 146082 [details]
Patch
Comment 2 Tony Chang 2012-06-06 12:37:01 PDT
Comment on attachment 146082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146082&action=review

> LayoutTests/css3/flexbox/flex-order.html:113
> -<div style="display: -webkit-flex" class="horizontal-box"></div>
> +<div style="" class="horizontal-box"></div>

Nit: Remove the empty style attribute?
Comment 3 Ojan Vafai 2012-06-06 12:43:51 PDT
Created attachment 146085 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-06-06 21:22:50 PDT
Comment on attachment 146085 [details]
Patch for landing

Rejecting attachment 146085 [details] from commit-queue.

New failing tests:
fast/multicol/span/clone-flexbox.html
fast/css/getComputedStyle/computed-style-without-renderer.html
fast/css/getComputedStyle/computed-style.html
svg/css/getComputedStyle-basic.xhtml
Full output: http://queues.webkit.org/results/12920052
Comment 5 WebKit Review Bot 2012-06-06 21:22:57 PDT
Created attachment 146189 [details]
Archive of layout-test-results from ec2-cq-03

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 6 Ojan Vafai 2012-06-12 12:06:58 PDT
Committed r120100: <http://trac.webkit.org/changeset/120100>