Bug 88426 - [GTK] Add API to get the library version to WebKit2 GTK+
Summary: [GTK] Add API to get the library version to WebKit2 GTK+
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2012-06-06 09:56 PDT by Carlos Garcia Campos
Modified: 2012-06-08 09:38 PDT (History)
3 users (show)

See Also:


Attachments
Patch (17.44 KB, patch)
2012-06-06 10:02 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Updated patch (16.60 KB, patch)
2012-06-08 00:50 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-06-06 09:56:42 PDT
WEBKIT_[MAJOR|MINOR|MICRO]_VERSION macros and webkit_get_[major|minor|micro]_version functions. And WEBKIT_CHECK_VERSION macro too would be useful.
Comment 1 Carlos Garcia Campos 2012-06-06 10:02:37 PDT
Created attachment 146052 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-06 10:05:44 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Martin Robinson 2012-06-06 10:57:11 PDT
Comment on attachment 146052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146052&action=review

> Source/WebKit2/GNUmakefile.am:12
> +	$(webkit2gtk_h_api) \
> +	$(webkit2gtk_built_h_api)

I'm fairly certain that you don't want to list webkit2gtk_built_h_api here, as they are already listed on a previous primary. This may even cause them to be distributed when running make dist. Removing them here would allow you do remove webkit2gtk_built_h_api entirely.
Comment 4 Carlos Garcia Campos 2012-06-08 00:47:25 PDT
(In reply to comment #3)
> (From update of attachment 146052 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146052&action=review
> 
> > Source/WebKit2/GNUmakefile.am:12
> > +	$(webkit2gtk_h_api) \
> > +	$(webkit2gtk_built_h_api)
> 
> I'm fairly certain that you don't want to list webkit2gtk_built_h_api here, as they are already listed on a previous primary. This may even cause them to be distributed when running make dist. Removing them here would allow you do remove webkit2gtk_built_h_api entirely.

Absolutely right
Comment 5 Carlos Garcia Campos 2012-06-08 00:50:53 PDT
Created attachment 146500 [details]
Updated patch
Comment 6 Carlos Garcia Campos 2012-06-08 09:38:08 PDT
Committed r119837: <http://trac.webkit.org/changeset/119837>