Bug 88426 – [GTK] Add API to get the library version to WebKit2 GTK+

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

WEBKIT_[MAJOR|MINOR|MICRO]_VERSION macros and webkit_get_[major|minor|micro]_version functions. And WEBKIT_CHECK_VERSION macro too would be useful.

[Carlos Garcia Campos]

Created attachment 146052 [details]
Patch

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Martin Robinson]

Comment on attachment 146052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146052&action=review

> Source/WebKit2/GNUmakefile.am:12
> +	$(webkit2gtk_h_api) \
> +	$(webkit2gtk_built_h_api)

I'm fairly certain that you don't want to list webkit2gtk_built_h_api here, as they are already listed on a previous primary. This may even cause them to be distributed when running make dist. Removing them here would allow you do remove webkit2gtk_built_h_api entirely.

[Carlos Garcia Campos]

(In reply to comment #3)
> (From update of attachment 146052 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146052&action=review
> 
> > Source/WebKit2/GNUmakefile.am:12
> > +	$(webkit2gtk_h_api) \
> > +	$(webkit2gtk_built_h_api)
> 
> I'm fairly certain that you don't want to list webkit2gtk_built_h_api here, as they are already listed on a previous primary. This may even cause them to be distributed when running make dist. Removing them here would allow you do remove webkit2gtk_built_h_api entirely.

Absolutely right

[Carlos Garcia Campos]

Created attachment 146500 [details]
Updated patch

[Carlos Garcia Campos]

Committed r119837: <http://trac.webkit.org/changeset/119837>