Bug 88409 - Ensure consistent order of evaluation in LLInt slow paths
Summary: Ensure consistent order of evaluation in LLInt slow paths
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Wingo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-06 05:00 PDT by Andy Wingo
Modified: 2012-06-06 11:59 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.07 KB, patch)
2012-06-06 05:02 PDT, Andy Wingo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Wingo 2012-06-06 05:00:30 PDT
The patch to be attached fixes a failure in fast/js/exception-sequencing-binops.html on x86-64 Linux systems with GCC 4.7.  The RHS of a % was getting evaluated before the LHS, because the toNumber() calls were not separated by a sequence point.  Pretty amusing that order of evaluation in JS depended on order of evaluation in C++, no?
Comment 1 Andy Wingo 2012-06-06 05:02:17 PDT
Created attachment 145992 [details]
Patch
Comment 2 Andy Wingo 2012-06-06 05:11:05 PDT
Only the mac EWS will be relevant, as bug 88315 hasn't landed yet.
Comment 3 Geoffrey Garen 2012-06-06 10:06:34 PDT
Comment on attachment 145992 [details]
Patch

r=me
Comment 4 WebKit Review Bot 2012-06-06 11:59:51 PDT
Comment on attachment 145992 [details]
Patch

Clearing flags on attachment: 145992

Committed r119602: <http://trac.webkit.org/changeset/119602>
Comment 5 WebKit Review Bot 2012-06-06 11:59:57 PDT
All reviewed patches have been landed.  Closing bug.