Greetings, Even though my r118479 <trac.webkit.org/changeset/118479> used dark gray (#555) for grammar markers on Linux and Windows, our UI people prefer light gray (#ccc) for them and I would like to change the color used for rendering grammar markers. Regards, Hironori Bono
Created attachment 145951 [details] Patch v0 (not ready for reviews) Greetings, I would like to upload a change and mark it as r? to run this change on EWS bots. (I wish I do not need more rebaselines.) Regards, Hironori Bono
Greetings Niwa-san and Morita-san, Would it be possible to review this small change (in terms of code). This change just replaces the color of grammar markers as requested by Glen. Regards, Hironori Bono
Comment on attachment 145951 [details] Patch v0 (not ready for reviews) View in context: https://bugs.webkit.org/attachment.cgi?id=145951&action=review > Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:560 > - 0xFF << SK_A32_SHIFT | 0x50 << SK_R32_SHIFT | 0x50 << SK_G32_SHIFT | 0x50 << SK_B32_SHIFT, // Opaque gray. > + 0xFF << SK_A32_SHIFT | 0xC0 << SK_R32_SHIFT | 0xC0 << SK_G32_SHIFT | 0xC0 << SK_B32_SHIFT, // Opaque gray. > }; > static const uint32_t antiColors[2] = { > 0x60 << SK_A32_SHIFT | 0x60 << SK_R32_SHIFT, // Semitransparent red > - 0xFF << SK_A32_SHIFT | 0x30 << SK_R32_SHIFT | 0x30 << SK_G32_SHIFT | 0x30 << SK_B32_SHIFT, // Semitransparent gray > + 0xFF << SK_A32_SHIFT | 0xC0 << SK_R32_SHIFT | 0xC0 << SK_G32_SHIFT | 0xC0 << SK_B32_SHIFT, // Semitransparent gray Should we have if-def for mac?
Comment on attachment 145951 [details] Patch v0 (not ready for reviews) View in context: https://bugs.webkit.org/attachment.cgi?id=145951&action=review >> Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:560 >> + 0xFF << SK_A32_SHIFT | 0xC0 << SK_R32_SHIFT | 0xC0 << SK_G32_SHIFT | 0xC0 << SK_B32_SHIFT, // Semitransparent gray > > Should we have if-def for mac? Fortunately, this file already has an if-def for Mac <http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp&exact_package=chromium&l=536>. (Mac uses green for compatibility with Safari.)
Comment on attachment 145951 [details] Patch v0 (not ready for reviews) Clearing flags on attachment: 145951 Committed r119693: <http://trac.webkit.org/changeset/119693>
All reviewed patches have been landed. Closing bug.