Bug 88391 - [EFL] Duplicated RenderThemeEfl creation for same page
Summary: [EFL] Duplicated RenderThemeEfl creation for same page
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-05 21:00 PDT by Ryuan Choi
Modified: 2017-03-11 10:33 PST (History)
6 users (show)

See Also:

Attachments
simpleApproach (2.08 KB, patch)
2012-09-20 08:13 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (1.73 KB, patch)
2012-09-20 17:55 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2012-06-05 21:00:19 PDT 
In case of EFL(Qt port looks similar also),
themeForPage with page create new RenderTheme every time although it is called with same page.
Comment 1 Ryuan Choi 2012-09-20 08:13:49 PDT 
Created attachment 164920 [details]
simpleApproach
Comment 2 Jinwoo Song 2012-09-20 17:27:54 PDT 
Comment on attachment 164920 [details]
simpleApproach

View in context: https://bugs.webkit.org/attachment.cgi?id=164920&action=review

> Source/WebCore/ChangeLog:3
> +        RenderThemeEfl is created more than one when themeForPage is called multiple time with same address of page.

Conciseness may be served when the title is so corrected, 'Duplicated RenderThemeEfl creation for same page'.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:431
> +    return RenderThemeEfl::create(page);

how about this?
return page->theme() ? page->theme() : RenderThemeEfl::create(page);
Comment 3 Ryuan Choi 2012-09-20 17:37:25 PDT 
(In reply to comment #2)
> (From update of attachment 164920 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164920&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        RenderThemeEfl is created more than one when themeForPage is called multiple time with same address of page.
> 
> Conciseness may be served when the title is so corrected, 'Duplicated RenderThemeEfl creation for same page'.
> 
I will change with '[EFL]' prefix.

> > Source/WebCore/platform/efl/RenderThemeEfl.cpp:431
> > +    return RenderThemeEfl::create(page);
> 
> how about this?
> return page->theme() ? page->theme() : RenderThemeEfl::create(page);

OK. I will.
Comment 4 Ryuan Choi 2012-09-20 17:55:19 PDT 
Created attachment 165025 [details]
Patch
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-09-21 02:42:03 PDT 
Seems to be OK.
Comment 6 Gyuyoung Kim 2012-09-23 23:08:51 PDT 
Comment on attachment 165025 [details]
Patch

Looks make sense.
Comment 7 WebKit Review Bot 2012-09-23 23:28:23 PDT 
Comment on attachment 165025 [details]
Patch

Clearing flags on attachment: 165025

Committed r129328: <http://trac.webkit.org/changeset/129328>
Comment 8 WebKit Review Bot 2012-09-23 23:28:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Ryuan Choi 2012-09-24 00:30:33 PDT 
The patch was reverted in Bug 97429 because of many crashes in layout tests, unit tests.
Comment 10 Michael Catanzaro 2017-03-11 10:33:21 PST 
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.