Bug 88391 – [EFL] Duplicated RenderThemeEfl creation for same page

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit EFL

[Ryuan Choi]

In case of EFL(Qt port looks similar also),
themeForPage with page create new RenderTheme every time although it is called with same page.

[Ryuan Choi]

Created attachment 164920 [details]
simpleApproach

[Jinwoo Song]

Comment on attachment 164920 [details]
simpleApproach

View in context: https://bugs.webkit.org/attachment.cgi?id=164920&action=review

> Source/WebCore/ChangeLog:3
> +        RenderThemeEfl is created more than one when themeForPage is called multiple time with same address of page.

Conciseness may be served when the title is so corrected, 'Duplicated RenderThemeEfl creation for same page'.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:431
> +    return RenderThemeEfl::create(page);

how about this?
return page->theme() ? page->theme() : RenderThemeEfl::create(page);

[Ryuan Choi]

(In reply to comment #2)
> (From update of attachment 164920 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164920&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        RenderThemeEfl is created more than one when themeForPage is called multiple time with same address of page.
> 
> Conciseness may be served when the title is so corrected, 'Duplicated RenderThemeEfl creation for same page'.
> 
I will change with '[EFL]' prefix.

> > Source/WebCore/platform/efl/RenderThemeEfl.cpp:431
> > +    return RenderThemeEfl::create(page);
> 
> how about this?
> return page->theme() ? page->theme() : RenderThemeEfl::create(page);

OK. I will.

[Ryuan Choi]

Created attachment 165025 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Seems to be OK.

[Gyuyoung Kim]

Comment on attachment 165025 [details]
Patch

Looks make sense.

[WebKit Review Bot]

Comment on attachment 165025 [details]
Patch

Clearing flags on attachment: 165025

Committed r129328: <http://trac.webkit.org/changeset/129328>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ryuan Choi]

The patch was reverted in Bug 97429 because of many crashes in layout tests, unit tests.

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.