Bug 88388 - [chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349
Summary: [chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ami Fischman
URL:
Keywords:
Depends on:
Blocks: 88349
  Show dependency treegraph
 
Reported: 2012-06-05 19:22 PDT by Ami Fischman
Modified: 2012-06-06 00:51 PDT (History)
9 users (show)

See Also:


Attachments
Patch (2.76 KB, patch)
2012-06-05 19:23 PDT, Ami Fischman
no flags Details | Formatted Diff | Diff
Patch (1.25 KB, patch)
2012-06-05 19:23 PDT, Ami Fischman
no flags Details | Formatted Diff | Diff
Patch (1.27 KB, patch)
2012-06-05 22:11 PDT, Ami Fischman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ami Fischman 2012-06-05 19:22:55 PDT
[chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349
Comment 1 Ami Fischman 2012-06-05 19:23:11 PDT
Created attachment 145915 [details]
Patch
Comment 2 Ami Fischman 2012-06-05 19:23:56 PDT
Created attachment 145916 [details]
Patch
Comment 3 WebKit Review Bot 2012-06-05 19:26:45 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Eric Carlson 2012-06-05 20:48:22 PDT
Comment on attachment 145916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145916&action=review

Looks fine to me, but I am not  abarth, dglazkov, fishd, jamesr or tkent...

> Source/WebKit/chromium/public/WebMediaPlayer.h:107
> +    enum CORSMode {
> +        Unspecified,
> +        Anonymous,
> +        UseCredentials,
> +    };

Shouldn't these have compile asserts in Source/WebKit/chromium/src/AssertMatchingEnums.cpp?
Comment 5 Ami Fischman 2012-06-05 20:54:27 PDT
(In reply to comment #4)
> (From update of attachment 145916 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145916&action=review
> > Source/WebKit/chromium/public/WebMediaPlayer.h:107
> > +    enum CORSMode {
> > +        Unspecified,
> > +        Anonymous,
> > +        UseCredentials,
> > +    };
> 
> Shouldn't these have compile asserts in Source/WebKit/chromium/src/AssertMatchingEnums.cpp?

They will (see 88349).  The point of *this* patch is just to be able to land https://chromiumcodereview.appspot.com/10543007/ so that I can then land 88349...
Comment 6 Darin Fisher (:fishd, Google) 2012-06-05 21:19:08 PDT
Comment on attachment 145916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145916&action=review

> Source/WebKit/chromium/public/WebMediaPlayer.h:103
> +    enum CORSMode {

nit: please fix enum naming:
http://trac.webkit.org/wiki/ChromiumWebKitAPI#Enums
Comment 7 Ami Fischman 2012-06-05 22:11:55 PDT
Created attachment 145933 [details]
Patch
Comment 8 Ami Fischman 2012-06-05 22:12:55 PDT
(In reply to comment #6)
> (From update of attachment 145916 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145916&action=review
> 
> > Source/WebKit/chromium/public/WebMediaPlayer.h:103
> > +    enum CORSMode {
> 
> nit: please fix enum naming:
> http://trac.webkit.org/wiki/ChromiumWebKitAPI#Enums

Done.
Comment 9 Darin Fisher (:fishd, Google) 2012-06-05 22:59:02 PDT
Comment on attachment 145933 [details]
Patch

(please remember to add the AssertMatchingEnums.cpp change)
Comment 10 WebKit Review Bot 2012-06-06 00:51:46 PDT
Comment on attachment 145933 [details]
Patch

Clearing flags on attachment: 145933

Committed r119569: <http://trac.webkit.org/changeset/119569>
Comment 11 WebKit Review Bot 2012-06-06 00:51:53 PDT
All reviewed patches have been landed.  Closing bug.