Bug 88388 – [chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ami Fischman]

[chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349

[Ami Fischman]

Created attachment 145915 [details]
Patch

[Ami Fischman]

Created attachment 145916 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Eric Carlson]

Comment on attachment 145916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145916&action=review

Looks fine to me, but I am not  abarth, dglazkov, fishd, jamesr or tkent...

> Source/WebKit/chromium/public/WebMediaPlayer.h:107
> +    enum CORSMode {
> +        Unspecified,
> +        Anonymous,
> +        UseCredentials,
> +    };

Shouldn't these have compile asserts in Source/WebKit/chromium/src/AssertMatchingEnums.cpp?

[Ami Fischman]

(In reply to comment #4)
> (From update of attachment 145916 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145916&action=review
> > Source/WebKit/chromium/public/WebMediaPlayer.h:107
> > +    enum CORSMode {
> > +        Unspecified,
> > +        Anonymous,
> > +        UseCredentials,
> > +    };
> 
> Shouldn't these have compile asserts in Source/WebKit/chromium/src/AssertMatchingEnums.cpp?

They will (see 88349).  The point of *this* patch is just to be able to land https://chromiumcodereview.appspot.com/10543007/ so that I can then land 88349...

[Darin Fisher (:fishd, Google)]

Comment on attachment 145916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145916&action=review

> Source/WebKit/chromium/public/WebMediaPlayer.h:103
> +    enum CORSMode {

nit: please fix enum naming:
http://trac.webkit.org/wiki/ChromiumWebKitAPI#Enums

[Ami Fischman]

Created attachment 145933 [details]
Patch

[Ami Fischman]

(In reply to comment #6)
> (From update of attachment 145916 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145916&action=review
> 
> > Source/WebKit/chromium/public/WebMediaPlayer.h:103
> > +    enum CORSMode {
> 
> nit: please fix enum naming:
> http://trac.webkit.org/wiki/ChromiumWebKitAPI#Enums

Done.

[Darin Fisher (:fishd, Google)]

Comment on attachment 145933 [details]
Patch

(please remember to add the AssertMatchingEnums.cpp change)

[WebKit Review Bot]

Comment on attachment 145933 [details]
Patch

Clearing flags on attachment: 145933

Committed r119569: <http://trac.webkit.org/changeset/119569>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.