[chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349
Created attachment 145915 [details] Patch
Created attachment 145916 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 145916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145916&action=review Looks fine to me, but I am not abarth, dglazkov, fishd, jamesr or tkent... > Source/WebKit/chromium/public/WebMediaPlayer.h:107 > + enum CORSMode { > + Unspecified, > + Anonymous, > + UseCredentials, > + }; Shouldn't these have compile asserts in Source/WebKit/chromium/src/AssertMatchingEnums.cpp?
(In reply to comment #4) > (From update of attachment 145916 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145916&action=review > > Source/WebKit/chromium/public/WebMediaPlayer.h:107 > > + enum CORSMode { > > + Unspecified, > > + Anonymous, > > + UseCredentials, > > + }; > > Shouldn't these have compile asserts in Source/WebKit/chromium/src/AssertMatchingEnums.cpp? They will (see 88349). The point of *this* patch is just to be able to land https://chromiumcodereview.appspot.com/10543007/ so that I can then land 88349...
Comment on attachment 145916 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145916&action=review > Source/WebKit/chromium/public/WebMediaPlayer.h:103 > + enum CORSMode { nit: please fix enum naming: http://trac.webkit.org/wiki/ChromiumWebKitAPI#Enums
Created attachment 145933 [details] Patch
(In reply to comment #6) > (From update of attachment 145916 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145916&action=review > > > Source/WebKit/chromium/public/WebMediaPlayer.h:103 > > + enum CORSMode { > > nit: please fix enum naming: > http://trac.webkit.org/wiki/ChromiumWebKitAPI#Enums Done.
Comment on attachment 145933 [details] Patch (please remember to add the AssertMatchingEnums.cpp change)
Comment on attachment 145933 [details] Patch Clearing flags on attachment: 145933 Committed r119569: <http://trac.webkit.org/changeset/119569>
All reviewed patches have been landed. Closing bug.