Bug 88379 - EventHandler shouldn't schedule the fake mousemove event timer when scrolling on devices that don't have a mouse
Summary: EventHandler shouldn't schedule the fake mousemove event timer when scrolling...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-05 17:16 PDT by Andy Estes
Modified: 2012-06-08 13:38 PDT (History)
4 users (show)

See Also:


Attachments
patch (3.58 KB, patch)
2012-06-08 12:26 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff
(committed r119862, r=jamesr) patch v2 (3.73 KB, patch)
2012-06-08 13:26 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2012-06-05 17:16:03 PDT
In <http://trac.webkit.org/changeset/119465> we stopped dispatching fake mousemove events when scrolling on devices that don't support mice. This event is dispatched on a timer, so one better would be to not even schedule the timer (rather than scheduling the timer but making it a no-op).
Comment 1 Antonio Gomes 2012-06-08 12:26:49 PDT
Created attachment 146630 [details]
patch
Comment 2 James Robinson 2012-06-08 12:57:12 PDT
Comment on attachment 146630 [details]
patch

There is the case of the setting changing between when the scroll happens and when the timer fires - maybe we should still check in the timer fire?
Comment 3 Antonio Gomes 2012-06-08 13:09:57 PDT
(In reply to comment #2)
> (From update of attachment 146630 [details])
> There is the case of the setting changing between when the scroll happens and when the timer fires - maybe we should still check in the timer fire?

though rare, it is a possible case, yes. Lets check both..
Comment 4 Antonio Gomes 2012-06-08 13:26:47 PDT
Created attachment 146637 [details]
(committed r119862, r=jamesr) patch v2