Bug 88368 - PrettyPatch.rb complains about missing checksum for new pixel results
Summary: PrettyPatch.rb complains about missing checksum for new pixel results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-05 15:37 PDT by Tony Chang
Modified: 2012-07-13 11:11 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.36 KB, patch)
2012-07-13 10:14 PDT, Ojan Vafai 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-06-05 15:37:09 PDT 
Here's an example: https://bugs.webkit.org/attachment.cgi?id=145881&action=review

LayoutTests/platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning-expected.png is a new file that has a checksum.
Comment 1 Ojan Vafai 2012-07-13 10:14:23 PDT 
Created attachment 152287 [details]
Patch
Comment 2 Tony Chang 2012-07-13 10:53:25 PDT 
Comment on attachment 152287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152287&action=review

> Websites/bugs.webkit.org/PrettyPatch/PrettyPatch_test.rb:74
> +        # FIXME: This should match, but there's a bug when running the tests where the image data
> +        # doesn't get properly written out the temp files, so we there there is no image and don't print

Missing preposition? "...doesn't get properly written out [to] the temp files..."
Extra 'we there'? "...so /we there/ there is no image..."

> Websites/bugs.webkit.org/PrettyPatch/PrettyPatch_test.rb:75
> +        # the warning that the image is missing it's checksum.

s/it's/its/
Comment 3 Ojan Vafai 2012-07-13 11:11:51 PDT 
Committed r122607: <http://trac.webkit.org/changeset/122607>