Bug 88362 - DFG CFG simplification should not attempt to deref nodes inside of an unreachable subgraph
Summary: DFG CFG simplification should not attempt to deref nodes inside of an unreach...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 87994 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-06-05 13:48 PDT by Filip Pizlo
Modified: 2012-06-05 14:40 PDT (History)
1 user (show)

See Also:


Attachments
the patch (2.19 KB, patch)
2012-06-05 13:53 PDT, Filip Pizlo
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-06-05 13:48:04 PDT
This is not only dangerous (you might go down an infinite deref recursion if you hit a dead cycle) but entirely unnecessary (the subgraph is going to get deleted anyway regardless of ref counts).
Comment 1 Filip Pizlo 2012-06-05 13:53:40 PDT
Created attachment 145865 [details]
the patch

Still trying to figure out the best way to test this.
Comment 2 Filip Pizlo 2012-06-05 14:32:45 PDT
Landed in http://trac.webkit.org/changeset/119526
Comment 3 Filip Pizlo 2012-06-05 14:40:38 PDT
*** Bug 87994 has been marked as a duplicate of this bug. ***