Bug 88351 - Change fast/sub-pixel/float-containing-block-with-margin.html to pixel test
Summary: Change fast/sub-pixel/float-containing-block-with-margin.html to pixel test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-05 11:28 PDT by Emil A Eklund
Modified: 2012-06-05 13:04 PDT (History)
1 user (show)

See Also:


Attachments
Patch (29.02 KB, patch)
2012-06-05 11:29 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-06-05 11:28:46 PDT
Change fast/sub-pixel/float-containing-block-with-margin.html to pixel test to allow for platform differences.
Comment 1 Emil A Eklund 2012-06-05 11:29:39 PDT
Created attachment 145846 [details]
Patch
Comment 2 Levi Weintraub 2012-06-05 12:01:00 PDT
Comment on attachment 145846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145846&action=review

> LayoutTests/ChangeLog:9
> +        Change fast/sub-pixel/float-containing-block-with-margin.html to pixel
> +        test to allow for platform differences.

It makes me a saaaaad panda to see tests go backwards here, but I get it. Perhaps a little more info would be handy?

> LayoutTests/ChangeLog:15
> +        * fast/sub-pixel/float-containing-block-with-margin-expected.html: Removed.
> +        * fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
> +        * fast/sub-pixel/float-containing-block-with-margin-expected.txt: Added.
> +        * fast/sub-pixel/float-containing-block-with-margin.html:
> +        * platform/chromium-mac/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.

Windows?
Comment 3 Emil A Eklund 2012-06-05 12:05:23 PDT
(In reply to comment #2)
> (From update of attachment 145846 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145846&action=review
> 
> > LayoutTests/ChangeLog:9
> > +        Change fast/sub-pixel/float-containing-block-with-margin.html to pixel
> > +        test to allow for platform differences.
> 
> It makes me a saaaaad panda to see tests go backwards here, but I get it. Perhaps a little more info would be handy?

It is unfortunate but the default styles for each platform makes it very hard to write a reftests that works on all.

> Windows?

I'll grab the windows image results from the bots as needed.
Comment 4 Levi Weintraub 2012-06-05 12:06:50 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 145846 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=145846&action=review
> > 
> > > LayoutTests/ChangeLog:9
> > > +        Change fast/sub-pixel/float-containing-block-with-margin.html to pixel
> > > +        test to allow for platform differences.
> > 
> > It makes me a saaaaad panda to see tests go backwards here, but I get it. Perhaps a little more info would be handy?
> 
> It is unfortunate but the default styles for each platform makes it very hard to write a reftests that works on all.
> 
> > Windows?
> 
> I'll grab the windows image results from the bots as needed.

Just be sure you mark 'em as failing/missing initially.
Comment 5 Emil A Eklund 2012-06-05 12:16:55 PDT
Committed r119512: <http://trac.webkit.org/changeset/119512>