WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
88342
[BlackBerry]Differentiate options and group options by TypeOption and TypeOptionInGroup
https://bugs.webkit.org/show_bug.cgi?id=88342
Summary
[BlackBerry]Differentiate options and group options by TypeOption and TypeOpt...
Crystal Zhang
Reported
2012-06-05 10:15:24 PDT
We set all options' type as TypeOption, which can't tell if an option belongs to a group, introduce TypeOptionInGroup to fix it.
Attachments
patch
(2.44 KB, patch)
2012-06-05 10:32 PDT
,
Crystal Zhang
rwlbuis
: review-
Details
Formatted Diff
Diff
updated patch
(2.51 KB, patch)
2012-06-05 10:45 PDT
,
Crystal Zhang
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Crystal Zhang
Comment 1
2012-06-05 10:32:03 PDT
Created
attachment 145833
[details]
patch
Rob Buis
Comment 2
2012-06-05 10:35:40 PDT
Comment on
attachment 145833
[details]
patch Please add PR number, Also not webkit style.
Crystal Zhang
Comment 3
2012-06-05 10:45:24 PDT
Created
attachment 145836
[details]
updated patch
Rob Buis
Comment 4
2012-06-05 10:48:03 PDT
Comment on
attachment 145836
[details]
updated patch LGTM.
Build Bot
Comment 5
2012-06-05 11:19:59 PDT
Comment on
attachment 145836
[details]
updated patch
Attachment 145836
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/12892702
WebKit Review Bot
Comment 6
2012-06-05 18:58:14 PDT
Comment on
attachment 145836
[details]
updated patch Clearing flags on attachment: 145836 Committed
r119549
: <
http://trac.webkit.org/changeset/119549
>
WebKit Review Bot
Comment 7
2012-06-05 18:58:21 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug