Bug 88342 - [BlackBerry]Differentiate options and group options by TypeOption and TypeOptionInGroup
Summary: [BlackBerry]Differentiate options and group options by TypeOption and TypeOpt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-05 10:15 PDT by Crystal Zhang
Modified: 2012-06-05 18:58 PDT (History)
2 users (show)

See Also:

Attachments
patch (2.44 KB, patch)
2012-06-05 10:32 PDT, Crystal Zhang 		rwlbuis: review-
Details | Formatted Diff | Diff
updated patch (2.51 KB, patch)
2012-06-05 10:45 PDT, Crystal Zhang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Crystal Zhang 2012-06-05 10:15:24 PDT 
We set all options' type as TypeOption, which can't tell if an option belongs to a group, introduce TypeOptionInGroup to fix it.
Comment 1 Crystal Zhang 2012-06-05 10:32:03 PDT 
Created attachment 145833 [details]
patch
Comment 2 Rob Buis 2012-06-05 10:35:40 PDT 
Comment on attachment 145833 [details]
patch

Please add PR number, Also not webkit style.
Comment 3 Crystal Zhang 2012-06-05 10:45:24 PDT 
Created attachment 145836 [details]
updated patch
Comment 4 Rob Buis 2012-06-05 10:48:03 PDT 
Comment on attachment 145836 [details]
updated patch

LGTM.
Comment 5 Build Bot 2012-06-05 11:19:59 PDT 
Comment on attachment 145836 [details]
updated patch

Attachment 145836 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12892702
Comment 6 WebKit Review Bot 2012-06-05 18:58:14 PDT 
Comment on attachment 145836 [details]
updated patch

Clearing flags on attachment: 145836

Committed r119549: <http://trac.webkit.org/changeset/119549>
Comment 7 WebKit Review Bot 2012-06-05 18:58:21 PDT 
All reviewed patches have been landed.  Closing bug.