Bug 88330 - [Qt] Fix harmattan builds broken by r119247.
Summary: [Qt] Fix harmattan builds broken by r119247.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Brüning
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-05 07:42 PDT by Michael Brüning
Modified: 2012-06-06 03:25 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.74 KB, patch)
2012-06-05 07:42 PDT, Michael Brüning
no flags Details | Formatted Diff | Diff
Patch (3.87 KB, patch)
2012-06-05 10:05 PDT, Michael Brüning
no flags Details | Formatted Diff | Diff
Patch (3.89 KB, patch)
2012-06-06 02:27 PDT, Michael Brüning
no flags Details | Formatted Diff | Diff
Patch (3.89 KB, patch)
2012-06-06 02:59 PDT, Michael Brüning
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Brüning 2012-06-05 07:42:03 PDT
[Qt] Fix harmattan builds broken by r119247.
Comment 1 Michael Brüning 2012-06-05 07:42:25 PDT
Created attachment 145792 [details]
Patch
Comment 2 Jocelyn Turcotte 2012-06-05 08:51:05 PDT
Comment on attachment 145792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145792&action=review

Looks good, just one comment.

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:370
> +#if OS(DARWIN)

Please protect it with #if defined(GL_ARB_texture_rectangle) instead.
Comment 3 Michael Brüning 2012-06-05 10:05:35 PDT
Created attachment 145825 [details]
Patch
Comment 4 Jocelyn Turcotte 2012-06-05 10:47:24 PDT
Comment on attachment 145825 [details]
Patch

Un-cq-ing it just to understand why using GL_TEXTURE_RECTANGLE_ARB instead of GL_ARB_texture_rectangle. The later should be used IMO instead (but yet just another nitpick).
Comment 5 Michael Brüning 2012-06-06 02:27:31 PDT
Created attachment 145966 [details]
Patch
Comment 6 Michael Brüning 2012-06-06 02:59:34 PDT
Created attachment 145972 [details]
Patch
Comment 7 WebKit Review Bot 2012-06-06 03:25:02 PDT
Comment on attachment 145972 [details]
Patch

Clearing flags on attachment: 145972

Committed r119579: <http://trac.webkit.org/changeset/119579>
Comment 8 WebKit Review Bot 2012-06-06 03:25:07 PDT
All reviewed patches have been landed.  Closing bug.