Bug 88328 - Fix border-image-slice failures on http://css3test.com.
Summary: Fix border-image-slice failures on http://css3test.com.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexis Menard (darktears)
URL:
Keywords:
Depends on:
Blocks: 79073
  Show dependency treegraph
 
Reported: 2012-06-05 05:54 PDT by Alexis Menard (darktears)
Modified: 2012-06-06 19:22 PDT (History)
4 users (show)

See Also:


Attachments
Patch (11.38 KB, patch)
2012-06-05 06:03 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff
Patch for landing (9.27 KB, patch)
2012-06-06 12:49 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2012-06-05 05:54:57 PDT
Fix border-image-slice failures on http://css3test.com.
Comment 1 Alexis Menard (darktears) 2012-06-05 06:03:42 PDT
Created attachment 145775 [details]
Patch
Comment 2 Tony Chang 2012-06-05 10:29:55 PDT
Comment on attachment 145775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145775&action=review

> LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image-slice.html:22
> +var testValues = [ "10", "30%", "10 10", "10 30%", "30% 30%", "10 10 10", "30% 10 10", "10 30% 10", "30% 30% 30% 10", "10 10 10 10", "30% 30% 30% 10", "30% 30% 30% 30%", "fill 30%", "fill 10", "fill 2 4 8% 16%",
> +                                "30% fill", "10 fill", "2 4 8% 16% fill", "10 fill 10", "solid", "fill fill" ];

Nit: weird indent

> LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image-slice.html:25
> +var expectedValues = [ "'10'", "'30%'", "'10'", "'10 30%'", "'30%'", "'10'", "'30% 10 10'", "'10 30%'", "'30% 30% 30% 10'", "'10'", "'30% 30% 30% 10'", "'30%'", "'30% fill'", "'10 fill'", "'2 4 8% 16% fill'",
> +                                "'30% fill'", "'10 fill'", "'2 4 8% 16% fill'", "'100%'", "'100%'", "'100%'" ];

Nit: weird indent

> LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image-slice.html:28
> +e.style.borderImageSlice = "";

Nit: bad indent

> LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image-slice.html:31
> +    shouldBe("computedStyle.getPropertyCSSValue('border-image-slice').toString()", "'[object CSSValue]'");

Nit: Is it useful to verify that it's a CSSValue?  This seems redundant to getting cssText.
Comment 3 Alexis Menard (darktears) 2012-06-06 12:49:42 PDT
Created attachment 146087 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-06-06 19:22:34 PDT
Comment on attachment 146087 [details]
Patch for landing

Clearing flags on attachment: 146087

Committed r119663: <http://trac.webkit.org/changeset/119663>
Comment 5 WebKit Review Bot 2012-06-06 19:22:42 PDT
All reviewed patches have been landed.  Closing bug.