Bug 88327 - [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
Summary: [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Brüning
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-05 05:53 PDT by Michael Brüning
Modified: 2012-06-06 03:13 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.08 KB, patch)
2012-06-05 05:54 PDT, Michael Brüning
no flags Details | Formatted Diff | Diff
Patch (5.26 KB, patch)
2012-06-05 06:02 PDT, Michael Brüning
no flags Details | Formatted Diff | Diff
Patch (5.26 KB, patch)
2012-06-05 06:12 PDT, Michael Brüning
no flags Details | Formatted Diff | Diff
Patch (8.13 KB, patch)
2012-06-05 09:38 PDT, Michael Brüning
no flags Details | Formatted Diff | Diff
Patch (8.01 KB, patch)
2012-06-06 02:39 PDT, Michael Brüning
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Brüning 2012-06-05 05:53:46 PDT
[Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
Comment 1 Michael Brüning 2012-06-05 05:54:39 PDT
Created attachment 145773 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-05 05:58:12 PDT
Attachment 145773 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Brüning 2012-06-05 06:01:36 PDT
Hm, seems I overestimated webkit-patch upload's abilities to deal with ChangeLog update on its own a bit... Or is there a special option for this?
Comment 4 Michael Brüning 2012-06-05 06:02:28 PDT
Created attachment 145774 [details]
Patch
Comment 5 Michael Brüning 2012-06-05 06:09:19 PDT
Comment on attachment 145774 [details]
Patch

Oops, sorry, small error when recreating the patch after. Fix coming in soon...
Comment 6 Michael Brüning 2012-06-05 06:12:30 PDT
Created attachment 145777 [details]
Patch
Comment 7 Kenneth Rohde Christiansen 2012-06-05 07:03:46 PDT
Comment on attachment 145774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145774&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:965
>      Q_D(QQuickWebView);
> +    if (width == d->webPageProxy->pageGroup()->preferences()->layoutFallbackWidth(width))
> +        return;
> +
>      d->webPageProxy->pageGroup()->preferences()->setLayoutFallbackWidth(width);

local prefs var?

> Tools/MiniBrowser/qt/qml/ViewportInfoItem.qml:79
>          Text {
> -            id: scalableLabel
> +            id: preferredMinimumContentsWidthLabel
>              anchors.top: layoutSizeLabel.bottom
> +            text: "Preferred minimum contents width: " + preferredMinimumContentsWidth

can we also set it? Like toggle between 980 and 0 :-)
Comment 8 Michael Brüning 2012-06-05 07:09:05 PDT
(In reply to comment #7)
> (From update of attachment 145774 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145774&action=review
> 
> > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:965
> >      Q_D(QQuickWebView);
> > +    if (width == d->webPageProxy->pageGroup()->preferences()->layoutFallbackWidth(width))
> > +        return;
> > +
> >      d->webPageProxy->pageGroup()->preferences()->setLayoutFallbackWidth(width);
> 
> local prefs var?
Sure, I'll add it...

> 
> > Tools/MiniBrowser/qt/qml/ViewportInfoItem.qml:79
> >          Text {
> > -            id: scalableLabel
> > +            id: preferredMinimumContentsWidthLabel
> >              anchors.top: layoutSizeLabel.bottom
> > +            text: "Preferred minimum contents width: " + preferredMinimumContentsWidth
> 
> can we also set it? Like toggle between 980 and 0 :-)
Sure, but I wanted to do that in separate patch.
Comment 9 Kenneth Rohde Christiansen 2012-06-05 07:10:46 PDT
Comment on attachment 145777 [details]
Patch

r=me but please do my changes
Comment 10 Michael Brüning 2012-06-05 09:38:39 PDT
Created attachment 145822 [details]
Patch
Comment 11 Build Bot 2012-06-05 10:24:42 PDT
Comment on attachment 145822 [details]
Patch

Attachment 145822 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12900549
Comment 12 Michael Brüning 2012-06-05 15:16:30 PDT
Comment on attachment 145822 [details]
Patch

Hm, this does not have touch any code other than the qt wk2 api and the qt MiniBrowser. Resetting flags to see if it was a temporary glitch.
Comment 13 Michael Brüning 2012-06-06 02:39:03 PDT
Created attachment 145968 [details]
Patch
Comment 14 WebKit Review Bot 2012-06-06 03:12:55 PDT
Comment on attachment 145968 [details]
Patch

Clearing flags on attachment: 145968

Committed r119578: <http://trac.webkit.org/changeset/119578>
Comment 15 WebKit Review Bot 2012-06-06 03:13:11 PDT
All reviewed patches have been landed.  Closing bug.