Bug 88327 – [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Michael Brüning]

[Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.

[Michael Brüning]

Created attachment 145773 [details]
Patch

[WebKit Review Bot]

Attachment 145773 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Brüning]

Hm, seems I overestimated webkit-patch upload's abilities to deal with ChangeLog update on its own a bit... Or is there a special option for this?

[Michael Brüning]

Created attachment 145774 [details]
Patch

[Michael Brüning]

Comment on attachment 145774 [details]
Patch

Oops, sorry, small error when recreating the patch after. Fix coming in soon...

[Michael Brüning]

Created attachment 145777 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 145774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145774&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:965
>      Q_D(QQuickWebView);
> +    if (width == d->webPageProxy->pageGroup()->preferences()->layoutFallbackWidth(width))
> +        return;
> +
>      d->webPageProxy->pageGroup()->preferences()->setLayoutFallbackWidth(width);

local prefs var?

> Tools/MiniBrowser/qt/qml/ViewportInfoItem.qml:79
>          Text {
> -            id: scalableLabel
> +            id: preferredMinimumContentsWidthLabel
>              anchors.top: layoutSizeLabel.bottom
> +            text: "Preferred minimum contents width: " + preferredMinimumContentsWidth

can we also set it? Like toggle between 980 and 0 :-)

[Michael Brüning]

(In reply to comment #7)
> (From update of attachment 145774 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145774&action=review
> 
> > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:965
> >      Q_D(QQuickWebView);
> > +    if (width == d->webPageProxy->pageGroup()->preferences()->layoutFallbackWidth(width))
> > +        return;
> > +
> >      d->webPageProxy->pageGroup()->preferences()->setLayoutFallbackWidth(width);
> 
> local prefs var?
Sure, I'll add it...

> 
> > Tools/MiniBrowser/qt/qml/ViewportInfoItem.qml:79
> >          Text {
> > -            id: scalableLabel
> > +            id: preferredMinimumContentsWidthLabel
> >              anchors.top: layoutSizeLabel.bottom
> > +            text: "Preferred minimum contents width: " + preferredMinimumContentsWidth
> 
> can we also set it? Like toggle between 980 and 0 :-)
Sure, but I wanted to do that in separate patch.

[Kenneth Rohde Christiansen]

Comment on attachment 145777 [details]
Patch

r=me but please do my changes

[Michael Brüning]

Created attachment 145822 [details]
Patch

[Build Bot]

Comment on attachment 145822 [details]
Patch

Attachment 145822 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12900549

[Michael Brüning]

Comment on attachment 145822 [details]
Patch

Hm, this does not have touch any code other than the qt wk2 api and the qt MiniBrowser. Resetting flags to see if it was a temporary glitch.

[Michael Brüning]

Created attachment 145968 [details]
Patch

[WebKit Review Bot]

Comment on attachment 145968 [details]
Patch

Clearing flags on attachment: 145968

Committed r119578: <http://trac.webkit.org/changeset/119578>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.