Bug 88318 - When the previous block has negative margin and float property, text is NOT displayed correctly following the floating box.
Summary: When the previous block has negative margin and float property, text is NOT d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-05 02:57 PDT by kyounga
Modified: 2013-11-05 08:42 PST (History)
9 users (show)

See Also:

Attachments
reduced test case (1.61 KB, text/html)
2012-06-05 02:57 PDT, kyounga 		no flags Details
first patch (1.95 KB, patch)
2012-06-11 02:31 PDT, kyounga 		no flags Details | Formatted Diff | Diff
first patch. (1.95 KB, patch)
2012-07-03 00:56 PDT, kyounga 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-01 (655.35 KB, application/zip)
2012-07-03 01:29 PDT, WebKit Review Bot 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kyounga 2012-06-05 02:57:54 PDT 
Created attachment 145741 [details]
reduced test case

I've attached the reduced test case. 
FireFox, Opera : OK.
Safari, Chrome : fails
Comment 1 mitz 2012-06-05 18:24:03 PDT 
I think this is a duplicate of bug 15956.
Comment 2 kyounga 2012-06-11 02:31:49 PDT 
Created attachment 146817 [details]
first patch
Comment 3 Levi Weintraub 2012-06-20 12:13:57 PDT 
(In reply to comment #1)
> I think this is a duplicate of bug 15956.

The test case on Bug 15956 repros in FFX, but this one does not.
Comment 4 kyounga 2012-07-03 00:56:58 PDT 
Created attachment 150553 [details]
first patch.
Comment 5 kyounga 2012-07-03 01:07:31 PDT 
I've attached my first patch again.
This is same with the previous one. 
Of course, it was tested on my mac (os X), but the build-bot reported error on mac-ews. 
I have no idea the why, so I'm just re-tried.

Please review this, and add any comments
Comment 6 WebKit Review Bot 2012-07-03 01:29:53 PDT 
Comment on attachment 150553 [details]
first patch. 

Attachment 150553 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13126402

New failing tests:
fast/block/float/previous-sibling-float-002.html
Comment 7 WebKit Review Bot 2012-07-03 01:29:57 PDT 
Created attachment 150558 [details]
Archive of layout-test-results from gce-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 8 kyounga 2012-07-12 19:06:36 PDT 
Honestly, I cannot understand this result. I mean, Is the test failed on only Chrome ? 
Both of browsers(Chrome, Safari) is based on same WebCore layout engine. isn't? 
If so, How the result is different? 

Or, If the engine is different, what should I do? 
Should I check the Chrome's layout engine or change the this issue's "platform" property like "mac only"?

Welcome any comments.please
Comment 9 Pravin D 2012-07-26 13:43:35 PDT 
(In reply to comment #8)
> Honestly, I cannot understand this result. I mean, Is the test failed on only Chrome ? 
> Both of browsers(Chrome, Safari) is based on same WebCore layout engine. isn't? 
> If so, How the result is different? 
> 
> Or, If the engine is different, what should I do? 
> Should I check the Chrome's layout engine or change the this issue's "platform" property like "mac only"?
> 
> Welcome any comments.please
> 
Only Chrome EWS runs the layout tests. If you run the same failing test case on the platform on which your working(with ur patch ) ur likely to get the same failure...
Comment 10 Robert Hogan 2013-09-16 10:57:24 PDT 
The rendering on trunk looks OK to me and is the same as FF. Please re-open and state the expected result if I'm wrong.
Comment 11 kyounga 2013-10-07 21:53:21 PDT 
resolved by https://bugs.webkit.org/show_bug.cgi?id=90646.
Comment 12 Csaba Osztrogonác 2013-11-05 08:42:03 PST 
Comment on attachment 150553 [details]
first patch. 

Cleared review? from attachment 150553 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).