Bug 88312 – [EFL] Remove Ewk_View_Smart_Data and Ewk_View_Smart_Class from public header.

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit EFL

[Tomasz Morawski]

Cleanup ewk_view.h file by move Ewk_View_Smart_Data and Ewk_View_Smart_Class to ewk_view_private.h file.
Move ewk_view_tiled_smart_set, ewk_view_smart_data_get and ewk_view_scrolls_process function to ewk_view_private
file.

[Tomasz Morawski]

Created attachment 145723 [details]
Patch

[Thiago Marcos P. Santos]

Comment on attachment 145723 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145723&action=review

> Source/WebKit/efl/ChangeLog:10
> +        file.

Would be nice to explain "why" and not "what". What I understood from the patch is: the API was public but only used by DRT. You made DRT include a private header instead, which IMO is not recommended.

> Source/WebKit/efl/ewk/ewk_view.cpp:2679
> + * @param o view object to get the internal data

Should be @param ewkView

> Source/WebKit/efl/ewk/ewk_view.cpp:2681
> + * @return the internal data of @a o, or @c 0 on failure

ditto

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:34
> +#include "ewk_view_private.h"

Looks to me that DRT needs the private methods to select the backing storage. Can it be done differently like in EWebLauncher? I know we are already including ewk_private.h (which is quite minimal now), but it should also be fixed.

[Tomasz Morawski]

(In reply to comment #2)
> Would be nice to explain "why" and not "what". What I understood from the patch is: the API was public but only used by DRT. You made DRT include a private header instead, which IMO is not recommended.
Yes, I also don't like that that the DRT include some private files. But I can understand that the DRT is not typical application it is an internal WebKit's tool that have to include some private headers. Anyway the ewk_private.h can be removed from include files now. I have just chacked that ewk_private.h is not needed in the DRT now.
 
I personally think that end application like browser doesn't need to make custom view class. Moreover, it looks like for me that the _Ewk_View_Smart_Class and _Ewk_View_Smart_Data struct ware deffined only inside ewk_view.h file because there ware not private headers file before. But I will not defend this patch. :) 

> > Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:34
> > +#include "ewk_view_private.h"
> 
> Looks to me that DRT needs the private methods to select the backing storage. Can it be done differently like in EWebLauncher? I know we are already including ewk_private.h (which is quite minimal now), but it should also be fixed.

The DRT uses _Ewk_View_Smart_Class structure make custom subclass of View_Smart_Class. It fills that structure to have custom methods. Please see Evas_Object* drtViewAdd(Evas* evas) function. The EWebLauncher uses deffined by ewk Views without change them.

Thanks for your comment.