Bug 88296 - REGRESSION (r118197): PluginStrategy should be used even if ENABLE(NETSCAPE_PLUGIN_API) is false
Summary: REGRESSION (r118197): PluginStrategy should be used even if ENABLE(NETSCAPE_P...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: Regression
Depends on: 87096
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-04 23:28 PDT by Andy Estes
Modified: 2012-06-05 11:28 PDT (History)
0 users

See Also:


Attachments
Patch (1.93 KB, patch)
2012-06-05 00:08 PDT, Andy Estes
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2012-06-04 23:28:00 PDT
<http://trac.webkit.org/changeset/118197> changed PluginData to only call into PluginStrategy if ENABLE(NETSCAPE_PLUGIN_API) is true. This isn't correct, since some ports support non-Netscape plug-ins and still use PluginStrategy (e.g. Apple's OS X port).
Comment 1 Andy Estes 2012-06-05 00:08:43 PDT
Created attachment 145707 [details]
Patch
Comment 2 mitz 2012-06-05 00:30:28 PDT
Comment on attachment 145707 [details]
Patch

r=me if it doesn’t break any builds
Comment 3 Andy Estes 2012-06-05 11:28:56 PDT
Committed r119506: <http://trac.webkit.org/changeset/119506>