Bug 88292 - [GTK] Build fix for Accelerated Compositing with OpenGL
Summary: [GTK] Build fix for Accelerated Compositing with OpenGL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-04 23:08 PDT by Joone Hur
Modified: 2012-06-06 00:29 PDT (History)
4 users (show)

See Also:


Attachments
Proposed Patch (2.48 KB, patch)
2012-06-05 00:20 PDT, Joone Hur
mrobinson: review+
mrobinson: commit-queue-
Details | Formatted Diff | Diff
Updated Patch (2.76 KB, patch)
2012-06-05 12:33 PDT, Joone Hur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joone Hur 2012-06-04 23:08:00 PDT
Currently, WebKitGtk+ doesn't need to include "GraphicsSurface.h" because USE(GRAPHICS_SURFACE) is not implemented.
Comment 1 Joone Hur 2012-06-05 00:20:49 PDT
Created attachment 145709 [details]
Proposed Patch
Comment 2 Martin Robinson 2012-06-05 08:10:04 PDT
Comment on attachment 145709 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145709&action=review

Looks good, but please fix the include order when landing.

> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h:28
> +
> +#if USE(GRAPHICS_SURFACE)
>  #include "GraphicsSurface.h"
> +#endif
> +

You should now move this include below the rest of them, so it should be like:

#include "FloatRect.h"
#include "Image.h"
#include "TextureMapper.h"
#include "TextureMapperPlatformLayer.h"
#include <wtf/RefPtr.h>

#if USE(GRAPHICS_SURFACE)
#include "GraphicsSurface.h"
#endif

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:28
>  #include "GraphicsContext.h"
> +
> +#if USE(GRAPHICS_SURFACE)
>  #include "GraphicsSurface.h"
> +#endif
> +

The same thing is necessary here.
Comment 3 Joone Hur 2012-06-05 12:33:28 PDT
Created attachment 145854 [details]
Updated Patch

Thanks for the review!
Comment 4 WebKit Review Bot 2012-06-06 00:29:51 PDT
Comment on attachment 145854 [details]
Updated Patch

Clearing flags on attachment: 145854

Committed r119567: <http://trac.webkit.org/changeset/119567>
Comment 5 WebKit Review Bot 2012-06-06 00:29:57 PDT
All reviewed patches have been landed.  Closing bug.