Bug 88286 – Web Inspector: Provide context menu for deleting recorded profile on Profiles Panel

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Rahul Tiwari]

On Profiles Panel, currently we can use "DELETE" button from keyboard to delete the selected profile. But it would be nice to have a context menu as well to do the job.

[Rahul Tiwari]

Patch to follow.

[Rahul Tiwari]

Created attachment 145781 [details]
Patch

[Pavel Feldman]

Comment on attachment 145781 [details]
Patch

LocalizedStrings is now UTF8 (not binary). Please edit it as text and convert to UTF8 if necessary. Otherwise looks good.

[Rahul Tiwari]

I checked the file type and it shows as utf 8 only with the svn mime-type as application octet stream.

(In reply to comment #3)
> (From update of attachment 145781 [details])
> LocalizedStrings is now UTF8 (not binary). Please edit it as text and convert to UTF8 if necessary. Otherwise looks good.

[Rahul Tiwari]

(In reply to comment #3)
> (From update of attachment 145781 [details])
> LocalizedStrings is now UTF8 (not binary). Please edit it as text and convert to UTF8 if necessary. Otherwise looks good.

Thank you Pavel.

I issued the following command to check the encoding of the file and got

file -bi localizedStrings.js => text/plain; charset=utf-8

But when I check the svn property on this file with

svn propget svn:mime-type localizedStrings.js => application/octet-stream

So is this the issue that you have pointed out? I apologize but I am little confused with these outputs and your comments. Please suggest.

[Rahul Tiwari]

Pavel, do you have any suggestions?

[Rahul Tiwari]

Created attachment 147066 [details]
Patch

[WebKit Review Bot]

Comment on attachment 147066 [details]
Patch

Rejecting attachment 147066 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Pavel Feld..." exit_code: 9 cwd: /mnt/git/webkit-commit-queue/

Failed to find the property value for the SVN property "svn:mime-type": "## -1 +0,0 ##
". at /mnt/git/webkit-commit-queue/Tools/Scripts/VCSUtils.pm line 1199, <ARGV> line 36.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Pavel Feld..." exit_code: 9 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12948454

[Pavel Feldman]

Committed r120070: <http://trac.webkit.org/changeset/120070>