WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
88285
Move some function definitions in EmptyClients.h to EmptyClients.cpp
https://bugs.webkit.org/show_bug.cgi?id=88285
Summary
Move some function definitions in EmptyClients.h to EmptyClients.cpp
Kent Tamura
Reported
2012-06-04 20:42:46 PDT
Move some function definitions in EmptyClients.h to EmptyClients.cpp to avoid to include unnecessary header files.
Attachments
Patch
(20.24 KB, patch)
2012-06-04 20:58 PDT
,
Kent Tamura
no flags
Details
Formatted Diff
Diff
Patch for landing
(19.69 KB, patch)
2012-06-04 21:18 PDT
,
Kent Tamura
no flags
Details
Formatted Diff
Diff
Patch for landing 2
(19.69 KB, patch)
2012-06-04 21:20 PDT
,
Kent Tamura
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2012-06-04 20:46:20 PDT
That sounds like a really good idea.
Kent Tamura
Comment 2
2012-06-04 20:58:46 PDT
Created
attachment 145687
[details]
Patch
Ryosuke Niwa
Comment 3
2012-06-04 21:06:25 PDT
Comment on
attachment 145687
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=145687&action=review
> Source/WebCore/loader/EmptyClients.cpp:65 > +// ----------------------------------------------------------------
I don't think we need these separators.
> Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:38 > #include "FocusController.h"
Can we also remove this?
> Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:45 > #include "WebInputEvent.h" > #include "WebInputEventConversion.h"
And these?
Kent Tamura
Comment 4
2012-06-04 21:18:03 PDT
Created
attachment 145690
[details]
Patch for landing
Kent Tamura
Comment 5
2012-06-04 21:20:04 PDT
Created
attachment 145691
[details]
Patch for landing 2
Kent Tamura
Comment 6
2012-06-04 21:20:43 PDT
Comment on
attachment 145687
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=145687&action=review
>> Source/WebCore/loader/EmptyClients.cpp:65 >> +// ---------------------------------------------------------------- > > I don't think we need these separators.
Removed
>> Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:38 >> #include "FocusController.h" > > Can we also remove this?
Removed
>> Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:45 >> #include "WebInputEventConversion.h" > > And these?
Removed
WebKit Review Bot
Comment 7
2012-06-05 02:08:23 PDT
Comment on
attachment 145691
[details]
Patch for landing 2 Clearing flags on attachment: 145691 Committed
r119470
: <
http://trac.webkit.org/changeset/119470
>
WebKit Review Bot
Comment 8
2012-06-05 02:08:28 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug