Bug 88285 - Move some function definitions in EmptyClients.h to EmptyClients.cpp
Summary: Move some function definitions in EmptyClients.h to EmptyClients.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-04 20:42 PDT by Kent Tamura
Modified: 2012-06-05 02:08 PDT (History)
4 users (show)

See Also:

Attachments
Patch (20.24 KB, patch)
2012-06-04 20:58 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch for landing (19.69 KB, patch)
2012-06-04 21:18 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch for landing 2 (19.69 KB, patch)
2012-06-04 21:20 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-06-04 20:42:46 PDT 
Move some function definitions in EmptyClients.h to EmptyClients.cpp to avoid to include unnecessary header files.
Comment 1 Ryosuke Niwa 2012-06-04 20:46:20 PDT 
That sounds like a really good idea.
Comment 2 Kent Tamura 2012-06-04 20:58:46 PDT 
Created attachment 145687 [details]
Patch
Comment 3 Ryosuke Niwa 2012-06-04 21:06:25 PDT 
Comment on attachment 145687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145687&action=review

> Source/WebCore/loader/EmptyClients.cpp:65
> +// ----------------------------------------------------------------

I don't think we need these separators.

> Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:38
>  #include "FocusController.h"

Can we also remove this?

> Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:45
>  #include "WebInputEvent.h"
>  #include "WebInputEventConversion.h"

And these?
Comment 4 Kent Tamura 2012-06-04 21:18:03 PDT 
Created attachment 145690 [details]
Patch for landing
Comment 5 Kent Tamura 2012-06-04 21:20:04 PDT 
Created attachment 145691 [details]
Patch for landing 2
Comment 6 Kent Tamura 2012-06-04 21:20:43 PDT 
Comment on attachment 145687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145687&action=review

>> Source/WebCore/loader/EmptyClients.cpp:65
>> +// ----------------------------------------------------------------
> 
> I don't think we need these separators.

Removed

>> Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:38
>>  #include "FocusController.h"
> 
> Can we also remove this?

Removed

>> Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:45
>>  #include "WebInputEventConversion.h"
> 
> And these?

Removed
Comment 7 WebKit Review Bot 2012-06-05 02:08:23 PDT 
Comment on attachment 145691 [details]
Patch for landing 2

Clearing flags on attachment: 145691

Committed r119470: <http://trac.webkit.org/changeset/119470>
Comment 8 WebKit Review Bot 2012-06-05 02:08:28 PDT 
All reviewed patches have been landed.  Closing bug.