Move some function definitions in EmptyClients.h to EmptyClients.cpp to avoid to include unnecessary header files.
That sounds like a really good idea.
Created attachment 145687 [details] Patch
Comment on attachment 145687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145687&action=review > Source/WebCore/loader/EmptyClients.cpp:65 > +// ---------------------------------------------------------------- I don't think we need these separators. > Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:38 > #include "FocusController.h" Can we also remove this? > Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:45 > #include "WebInputEvent.h" > #include "WebInputEventConversion.h" And these?
Created attachment 145690 [details] Patch for landing
Created attachment 145691 [details] Patch for landing 2
Comment on attachment 145687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145687&action=review >> Source/WebCore/loader/EmptyClients.cpp:65 >> +// ---------------------------------------------------------------- > > I don't think we need these separators. Removed >> Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:38 >> #include "FocusController.h" > > Can we also remove this? Removed >> Source/WebKit/chromium/src/WebHelperPluginImpl.cpp:45 >> #include "WebInputEventConversion.h" > > And these? Removed
Comment on attachment 145691 [details] Patch for landing 2 Clearing flags on attachment: 145691 Committed r119470: <http://trac.webkit.org/changeset/119470>
All reviewed patches have been landed. Closing bug.