Bug 88273 - nrwt should look in 'out' for binaries on chromium win to support ninja
Summary: nrwt should look in 'out' for binaries on chromium win to support ninja
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-04 17:55 PDT by Dirk Pranke
Modified: 2012-06-06 17:32 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.75 KB, patch)
2012-06-04 18:00 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
Patch (20.52 KB, patch)
2012-06-06 17:18 PDT, Dirk Pranke
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-06-04 17:55:25 PDT
nrwt should look in 'out' for binaries on chromium win to support ninja
Comment 1 Dirk Pranke 2012-06-04 18:00:37 PDT
Created attachment 145670 [details]
Patch
Comment 2 Tony Chang 2012-06-05 09:52:33 PDT
Comment on attachment 145670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145670&action=review

> Tools/ChangeLog:3
> +        nrwt should look in 'out' for binaries on chromium win to support ninja

With this change, mac, linux, and win all look in 'out' (sometimes first, sometimes second).  It would be nice if we pushed the out logic up into chromium.py.
Comment 3 Dirk Pranke 2012-06-05 13:06:43 PDT
(In reply to comment #2)
> (From update of attachment 145670 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145670&action=review
> 
> > Tools/ChangeLog:3
> > +        nrwt should look in 'out' for binaries on chromium win to support ninja
> 
> With this change, mac, linux, and win all look in 'out' (sometimes first, sometimes second).  It would be nice if we pushed the out logic up into chromium.py.

This is a fair point. Each port uses different logic as well as different locations, but that's probably not a good thing. I'll see if I can unify them.
Comment 4 Dirk Pranke 2012-06-06 17:18:12 PDT
Created attachment 146154 [details]
Patch
Comment 5 Dirk Pranke 2012-06-06 17:32:04 PDT
Committed r119649: <http://trac.webkit.org/changeset/119649>