nrwt should look in 'out' for binaries on chromium win to support ninja
Created attachment 145670 [details] Patch
Comment on attachment 145670 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145670&action=review > Tools/ChangeLog:3 > + nrwt should look in 'out' for binaries on chromium win to support ninja With this change, mac, linux, and win all look in 'out' (sometimes first, sometimes second). It would be nice if we pushed the out logic up into chromium.py.
(In reply to comment #2) > (From update of attachment 145670 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145670&action=review > > > Tools/ChangeLog:3 > > + nrwt should look in 'out' for binaries on chromium win to support ninja > > With this change, mac, linux, and win all look in 'out' (sometimes first, sometimes second). It would be nice if we pushed the out logic up into chromium.py. This is a fair point. Each port uses different logic as well as different locations, but that's probably not a good thing. I'll see if I can unify them.
Created attachment 146154 [details] Patch
Committed r119649: <http://trac.webkit.org/changeset/119649>