RESOLVED FIXED Bug 88258
Remove enabledProfilerReference 
https://bugs.webkit.org/show_bug.cgi?id=88258
Summary Remove enabledProfilerReference
Gavin Barraclough
Reported 2012-06-04 14:50:57 PDT
Make the enabled profiler a member of JSGlobalData, and switch code that accesses it to do so directly via the JSGlobalData, rather than holding a Profiler** reference to it. Do not pass the Profiler** reference to JIT code. This patch does not change the stack layout on entry into JIT code (passing an unused void* instead), since this is an intrusive change better handled in a separate patch.
Attachments
Fix (30.36 KB, patch)
2012-06-04 15:08 PDT, Gavin Barraclough 		msaboff: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Windows build fix (31.52 KB, patch)
2012-06-04 16:05 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2012-06-04 15:08:27 PDT
Created attachment 145637 [details] Fix
WebKit Review Bot
Comment 2 2012-06-04 15:11:52 PDT
Attachment 145637 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1549: The parameter name "profiler" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1557: The parameter name "profiler" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2012-06-04 15:53:59 PDT
Comment on attachment 145637 [details] Fix Attachment 145637 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12896385
Gavin Barraclough
Comment 4 2012-06-04 16:05:00 PDT
Created attachment 145645 [details] Windows build fix
WebKit Review Bot
Comment 5 2012-06-04 16:07:13 PDT
Attachment 145645 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1549: The parameter name "profiler" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1557: The parameter name "profiler" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 6 2012-06-04 17:00:32 PDT
Fixed in r119441
Patrick R. Gansterer
Comment 7 2012-06-07 16:26:08 PDT
Build fix after r119441: http://trac.webkit.org/changeset/119768
Note You need to log in before you can comment on or make changes to this bug.