Bug 88258 - Remove enabledProfilerReference
Summary: Remove enabledProfilerReference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-04 14:50 PDT by Gavin Barraclough
Modified: 2012-06-07 16:26 PDT (History)
2 users (show)

See Also:


Attachments
Fix (30.36 KB, patch)
2012-06-04 15:08 PDT, Gavin Barraclough
msaboff: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Windows build fix (31.52 KB, patch)
2012-06-04 16:05 PDT, Gavin Barraclough
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2012-06-04 14:50:57 PDT
Make the enabled profiler a member of JSGlobalData, and switch code that accesses it to do so directly via the JSGlobalData, rather than holding a Profiler** reference to it. Do not pass the Profiler** reference to JIT code. This patch does not change the stack layout on entry into JIT code (passing an unused void* instead), since this is an intrusive change better handled in a separate patch.
Comment 1 Gavin Barraclough 2012-06-04 15:08:27 PDT
Created attachment 145637 [details]
Fix
Comment 2 WebKit Review Bot 2012-06-04 15:11:52 PDT
Attachment 145637 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1549:  The parameter name "profiler" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1557:  The parameter name "profiler" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2012-06-04 15:53:59 PDT
Comment on attachment 145637 [details]
Fix

Attachment 145637 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12896385
Comment 4 Gavin Barraclough 2012-06-04 16:05:00 PDT
Created attachment 145645 [details]
Windows build fix
Comment 5 WebKit Review Bot 2012-06-04 16:07:13 PDT
Attachment 145645 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1549:  The parameter name "profiler" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1557:  The parameter name "profiler" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Gavin Barraclough 2012-06-04 17:00:32 PDT
Fixed in r119441
Comment 7 Patrick R. Gansterer 2012-06-07 16:26:08 PDT
Build fix after r119441: http://trac.webkit.org/changeset/119768