Bug 88251 - Some shadow roots are not showing up in Inspector
Summary: Some shadow roots are not showing up in Inspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL: http://jsfiddle.net/dglazkov/b8QXN/
Keywords:
Depends on:
Blocks: 72352 62220
  Show dependency treegraph
 
Reported: 2012-06-04 13:09 PDT by Dimitri Glazkov (Google)
Modified: 2012-10-11 05:49 PDT (History)
9 users (show)

See Also:


Attachments
Patch (6.34 KB, patch)
2012-09-27 06:40 PDT, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (6.33 KB, patch)
2012-10-08 18:47 PDT, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (6.35 KB, patch)
2012-10-11 03:38 PDT, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch for landing (6.24 KB, patch)
2012-10-11 05:18 PDT, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2012-06-04 13:09:42 PDT
To repro:

1) Turn on shadow DOM inspecton
2) Go to http://jsfiddle.net/dglazkov/b8QXN/
3) Inspect the "Result" pane and look for shadow roots

You'll find that only the first shadow root is showing.
Comment 1 Shinya Kawanaka 2012-09-25 23:19:10 PDT
it seems elements having no children (except text) does not show shadow roots, since they will not have any triangle marker by default.

I'm preparing a patch for this. This bug is very annoying when debugging ShadowDOM related stuffs, so I would like to fix as soon as possible.
Comment 2 Shinya Kawanaka 2012-09-25 23:56:02 PDT
Ah, an element having no children is wrong, an element having only text is correct.
Comment 3 Shinya Kawanaka 2012-09-27 06:40:56 PDT
Created attachment 165991 [details]
Patch
Comment 4 Shinya Kawanaka 2012-10-08 18:47:17 PDT
Created attachment 167668 [details]
Patch
Comment 5 Build Bot 2012-10-08 19:36:55 PDT
Comment on attachment 167668 [details]
Patch

Attachment 167668 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14228460

New failing tests:
inspector/elements/shadow-dom-modify-chardata.html
inspector/elements/edit-dom-actions.html
inspector/elements/elements-panel-search.html
inspector/elements/shadow-root.html
inspector/elements/elements-panel-reload-assert.html
inspector/console/console-format-collections.html
Comment 6 WebKit Review Bot 2012-10-08 20:23:40 PDT
Comment on attachment 167668 [details]
Patch

Attachment 167668 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14221516

New failing tests:
inspector/elements/elements-panel-search.html
inspector/elements/shadow-dom-modify-chardata.html
inspector/elements/elements-panel-reload-assert.html
inspector/elements/shadow-root.html
inspector/elements/edit-dom-actions.html
Comment 7 Shinya Kawanaka 2012-10-09 01:55:34 PDT
Ohya
Comment 8 Pavel Feldman 2012-10-10 00:33:25 PDT
Comment on attachment 167668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167668&action=review

> Source/WebCore/inspector/front-end/DOMAgent.js:70
> +    if (payload.shadowRoots && WebInspector.experimentsSettings.showShadowDOM.isEnabled()) {

Experiments? It sounds like a poor merge.
Comment 9 Shinya Kawanaka 2012-10-11 03:38:44 PDT
Created attachment 168187 [details]
Patch
Comment 10 Pavel Feldman 2012-10-11 04:20:34 PDT
Comment on attachment 168187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168187&action=review

> LayoutTests/inspector/elements/shadow-root.html:21
> +    // For insurance.

We never do such things. Let the test timeout instead.
Comment 11 Shinya Kawanaka 2012-10-11 05:18:39 PDT
Created attachment 168198 [details]
Patch for landing
Comment 12 WebKit Review Bot 2012-10-11 05:49:47 PDT
Comment on attachment 168198 [details]
Patch for landing

Clearing flags on attachment: 168198

Committed r131046: <http://trac.webkit.org/changeset/131046>
Comment 13 WebKit Review Bot 2012-10-11 05:49:51 PDT
All reviewed patches have been landed.  Closing bug.