Bug 88247 – [Qt][WK2] Use Component.onCompleted in API tests for single and multi file upload tests.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Dinu Jacob]

With 855a3ec2, there is no need for the Timer hack in single file upload and multi-file upload API tests.

[Dinu Jacob]

Created attachment 145618 [details]
Patch

[Caio Marcelo de Oliveira Filho]

Comment on attachment 145618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145618&action=review

> Source/WebKit2/ChangeLog:8
> +        With commit 855a3ec2, Component.onCompleted can be used for callback instead of the

To which repository does this commit refer?

[Dinu Jacob]

(In reply to comment #2)
> (From update of attachment 145618 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145618&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        With commit 855a3ec2, Component.onCompleted can be used for callback instead of the
> 
> To which repository does this commit refer?

ah, the git repository. I guess I should use the revision number instead!

[Dinu Jacob]

Created attachment 145849 [details]
Patch

Updated the ChangeLog to use the revision number instead of the git commit id.

[WebKit Review Bot]

Comment on attachment 145849 [details]
Patch

Clearing flags on attachment: 145849

Committed r119559: <http://trac.webkit.org/changeset/119559>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.