Bug 88247 - [Qt][WK2] Use Component.onCompleted in API tests for single and multi file upload tests.
Summary: [Qt][WK2] Use Component.onCompleted in API tests for single and multi file up...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-04 12:34 PDT by Dinu Jacob
Modified: 2012-06-05 22:32 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.09 KB, patch)
2012-06-04 12:48 PDT, Dinu Jacob
no flags Details | Formatted Diff | Diff
Patch (3.08 KB, patch)
2012-06-05 11:49 PDT, Dinu Jacob
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dinu Jacob 2012-06-04 12:34:23 PDT
With 855a3ec2, there is no need for the Timer hack in single file upload and multi-file upload API tests.
Comment 1 Dinu Jacob 2012-06-04 12:48:45 PDT
Created attachment 145618 [details]
Patch
Comment 2 Caio Marcelo de Oliveira Filho 2012-06-05 11:42:39 PDT
Comment on attachment 145618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145618&action=review

> Source/WebKit2/ChangeLog:8
> +        With commit 855a3ec2, Component.onCompleted can be used for callback instead of the

To which repository does this commit refer?
Comment 3 Dinu Jacob 2012-06-05 11:45:10 PDT
(In reply to comment #2)
> (From update of attachment 145618 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145618&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        With commit 855a3ec2, Component.onCompleted can be used for callback instead of the
> 
> To which repository does this commit refer?

ah, the git repository. I guess I should use the revision number instead!
Comment 4 Dinu Jacob 2012-06-05 11:49:35 PDT
Created attachment 145849 [details]
Patch

Updated the ChangeLog to use the revision number instead of the git commit id.
Comment 5 WebKit Review Bot 2012-06-05 22:32:43 PDT
Comment on attachment 145849 [details]
Patch

Clearing flags on attachment: 145849

Committed r119559: <http://trac.webkit.org/changeset/119559>
Comment 6 WebKit Review Bot 2012-06-05 22:32:49 PDT
All reviewed patches have been landed.  Closing bug.