Bug 88246 - [chromium] Remove redundant setNeedsCommit when prepareToDraw fails
Summary: [chromium] Remove redundant setNeedsCommit when prepareToDraw fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-04 12:33 PDT by Dana Jansens
Modified: 2012-06-05 08:20 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.48 KB, patch)
2012-06-04 12:38 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cq-03 (817.24 KB, application/zip)
2012-06-04 17:44 PDT, WebKit Review Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-06-04 12:33:38 PDT 
[chromium] Remove redundant setNeedsCommit when prepareToDraw fails
Comment 1 Dana Jansens 2012-06-04 12:38:52 PDT 
Created attachment 145616 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-04 17:44:10 PDT 
Comment on attachment 145616 [details]
Patch

Rejecting attachment 145616 [details] from commit-queue.

New failing tests:
perf/object-keys.html
Full output: http://queues.webkit.org/results/12903324
Comment 3 WebKit Review Bot 2012-06-04 17:44:14 PDT 
Created attachment 145664 [details]
Archive of layout-test-results from ec2-cq-03

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 James Robinson 2012-06-04 17:47:51 PDT 
Comment on attachment 145616 [details]
Patch

That would be a flake
Comment 5 WebKit Review Bot 2012-06-04 18:07:47 PDT 
Comment on attachment 145616 [details]
Patch

Clearing flags on attachment: 145616

Committed r119447: <http://trac.webkit.org/changeset/119447>
Comment 6 WebKit Review Bot 2012-06-04 18:07:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Dana Jansens 2012-06-05 08:20:28 PDT 
Thanks for re-cq'ing for me