Bug 88243 - Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
Summary: Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hugo Parente Lima
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-04 11:53 PDT by Hugo Parente Lima
Modified: 2012-06-04 20:01 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.31 KB, patch)
2012-06-04 11:57 PDT, Hugo Parente Lima 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hugo Parente Lima 2012-06-04 11:53:01 PDT 
Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag, as it better fits into ENABLE flag definition.
Comment 1 Hugo Parente Lima 2012-06-04 11:57:15 PDT 
Created attachment 145613 [details]
Patch
Comment 2 Adam Barth 2012-06-04 12:00:05 PDT 
Comment on attachment 145613 [details]
Patch

Is LEGACY_VIEWPORT_ADAPTION only mentioned in the cmake build system?  I would have expected you to change some of the other build systems as well.
Comment 3 Hugo Parente Lima 2012-06-04 12:08:14 PDT 
Yes, I only added it on qmake and cmake (false by default), but as the default value should be false on other ports until the respective maintainers take the decision to turn it on this shall be no problem.
Comment 4 Hugo Parente Lima 2012-06-04 12:10:47 PDT 
Continuing..., as the feature is off by default, better to delegate the implementation of this flag on other build system to people that really understand those build systems, when and if they decide to use this feature.
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-06-04 13:20:37 PDT 
Comment on attachment 145613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145613&action=review

> Source/cmake/WebKitFeatures.cmake:59
> +    WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VIEWPORT_ADAPTION "Toogle legacy viewport adaption" OFF)

BTW, for CMake you also need to change Source/cmakeconfig.h.cmake.
Comment 6 Hugo Parente Lima 2012-06-04 14:43:34 PDT 
(In reply to comment #5)
> (From update of attachment 145613 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145613&action=review
> 
> > Source/cmake/WebKitFeatures.cmake:59
> > +    WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VIEWPORT_ADAPTION "Toogle legacy viewport adaption" OFF)
> 
> BTW, for CMake you also need to change Source/cmakeconfig.h.cmake.

I saw the file, but I was not sure if adding the flag there would enable the feature, so for the sake of not mess with other ports I didn't touch the file.

rakuko, could you complete the addition of this feature flag for cmake?
Comment 7 WebKit Review Bot 2012-06-04 20:01:36 PDT 
Comment on attachment 145613 [details]
Patch

Clearing flags on attachment: 145613

Committed r119452: <http://trac.webkit.org/changeset/119452>
Comment 8 WebKit Review Bot 2012-06-04 20:01:41 PDT 
All reviewed patches have been landed.  Closing bug.