RESOLVED FIXED 88243
Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag. 
https://bugs.webkit.org/show_bug.cgi?id=88243
Summary Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
Hugo Parente Lima
Reported 2012-06-04 11:53:01 PDT
Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag, as it better fits into ENABLE flag definition.
Attachments
Patch (6.31 KB, patch)
2012-06-04 11:57 PDT, Hugo Parente Lima 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hugo Parente Lima
Comment 1 2012-06-04 11:57:15 PDT
Created attachment 145613 [details] Patch
Adam Barth
Comment 2 2012-06-04 12:00:05 PDT
Comment on attachment 145613 [details] Patch Is LEGACY_VIEWPORT_ADAPTION only mentioned in the cmake build system? I would have expected you to change some of the other build systems as well.
Hugo Parente Lima
Comment 3 2012-06-04 12:08:14 PDT
Yes, I only added it on qmake and cmake (false by default), but as the default value should be false on other ports until the respective maintainers take the decision to turn it on this shall be no problem.
Hugo Parente Lima
Comment 4 2012-06-04 12:10:47 PDT
Continuing..., as the feature is off by default, better to delegate the implementation of this flag on other build system to people that really understand those build systems, when and if they decide to use this feature.
Raphael Kubo da Costa (:rakuco)
Comment 5 2012-06-04 13:20:37 PDT
Comment on attachment 145613 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145613&action=review > Source/cmake/WebKitFeatures.cmake:59 > + WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VIEWPORT_ADAPTION "Toogle legacy viewport adaption" OFF) BTW, for CMake you also need to change Source/cmakeconfig.h.cmake.
Hugo Parente Lima
Comment 6 2012-06-04 14:43:34 PDT
(In reply to comment #5) > (From update of attachment 145613 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145613&action=review > > > Source/cmake/WebKitFeatures.cmake:59 > > + WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VIEWPORT_ADAPTION "Toogle legacy viewport adaption" OFF) > > BTW, for CMake you also need to change Source/cmakeconfig.h.cmake. I saw the file, but I was not sure if adding the flag there would enable the feature, so for the sake of not mess with other ports I didn't touch the file. rakuko, could you complete the addition of this feature flag for cmake?
WebKit Review Bot
Comment 7 2012-06-04 20:01:36 PDT
Comment on attachment 145613 [details] Patch Clearing flags on attachment: 145613 Committed r119452: <http://trac.webkit.org/changeset/119452>
WebKit Review Bot
Comment 8 2012-06-04 20:01:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.