Bug 88226 - [Qt][WK2] Rename QtViewportInteractionEngine to QtViewportHandler
Summary: [Qt][WK2] Rename QtViewportInteractionEngine to QtViewportHandler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-04 04:57 PDT by zalan
Modified: 2012-06-04 08:31 PDT (History)
6 users (show)

See Also:

Attachments
Patch (113.44 KB, patch)
2012-06-04 06:15 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (112.88 KB, patch)
2012-06-04 07:18 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2012-06-04 04:57:13 PDT 
as discussed with Kenneth and Simon. New name reflects functionality better.
Comment 1 zalan 2012-06-04 06:15:49 PDT 
Created attachment 145572 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-06-04 06:26:24 PDT 
Comment on attachment 145572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145572&action=review

> Source/WebKit2/UIProcess/qt/QtViewportHandler.cpp:689
> +QRect QtViewportInteractionEngine::visibleContentsRect() const

huh? half rename?
Comment 3 zalan 2012-06-04 06:29:29 PDT 
(In reply to comment #2)
> (From update of attachment 145572 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145572&action=review
> 
> > Source/WebKit2/UIProcess/qt/QtViewportHandler.cpp:689
> > +QRect QtViewportInteractionEngine::visibleContentsRect() const
> 
> huh? half rename?

uh, probably wrong diff. :(
Comment 4 zalan 2012-06-04 06:33:35 PDT 
Comment on attachment 145572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145572&action=review

>>> Source/WebKit2/UIProcess/qt/QtViewportHandler.cpp:689
>>> +QRect QtViewportHandler::visibleContentsRect() const
>> 
>> huh? half rename?
> 
> uh, probably wrong diff. :(

actually it shows - for Interaction and + for Handler in my view. and my local copy is like that too.
Comment 5 Kenneth Rohde Christiansen 2012-06-04 06:34:22 PDT 
anyway rs=me but can you land manually?
Comment 6 zalan 2012-06-04 07:18:50 PDT 
Created attachment 145580 [details]
Patch
Comment 7 Kenneth Rohde Christiansen 2012-06-04 07:21:32 PDT 
Comment on attachment 145580 [details]
Patch

lets hope this is correct and just due to the renaming... or lets do the file renaming separately
Comment 8 WebKit Review Bot 2012-06-04 08:31:04 PDT 
Comment on attachment 145580 [details]
Patch

Clearing flags on attachment: 145580

Committed r119400: <http://trac.webkit.org/changeset/119400>
Comment 9 WebKit Review Bot 2012-06-04 08:31:09 PDT 
All reviewed patches have been landed.  Closing bug.