Bug 88209 - Use SelectorQuery in Element::webkitMatchesSelector()
Summary: Use SelectorQuery in Element::webkitMatchesSelector()
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 87625
  Show dependency treegraph
Reported: 2012-06-03 20:55 PDT by Kentaro Hara
Modified: 2012-06-04 01:52 PDT (History)
4 users (show)

See Also:

Patch (4.02 KB, patch)
2012-06-03 20:58 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-06-03 20:55:17 PDT
By using SelectorQuery in Element::webkitMatchesSelector(), we can not only simplify the code but also improve the performance thanks to the cache mechanism of SelectorQuery which was implemented in bug 87942.
Comment 1 Kentaro Hara 2012-06-03 20:58:25 PDT
Created attachment 145511 [details]
Comment 2 Kentaro Hara 2012-06-03 20:59:07 PDT
I've found that SelectorDataList::matches() had been used by nobody before this patch:)
Comment 3 Antti Koivisto 2012-06-04 01:39:37 PDT
Comment on attachment 145511 [details]

Comment 4 WebKit Review Bot 2012-06-04 01:52:24 PDT
Comment on attachment 145511 [details]

Clearing flags on attachment: 145511

Committed r119375: <http://trac.webkit.org/changeset/119375>
Comment 5 WebKit Review Bot 2012-06-04 01:52:30 PDT
All reviewed patches have been landed.  Closing bug.