Bug 88207 - [EFL][WK2] Make WebKit2/Efl headers and resources installable.
Summary: [EFL][WK2] Make WebKit2/Efl headers and resources installable.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on: 84124 88767
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-03 20:09 PDT by Ryuan Choi
Modified: 2012-06-21 08:47 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.90 KB, patch)
2012-06-10 16:44 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff
Patch (2.94 KB, patch)
2012-06-11 23:23 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff
Patch (5.28 KB, patch)
2012-06-21 07:45 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2012-06-03 20:09:13 PDT
WebKit2/Efl should install public header files and .pc for separated webkit2-efl based project.
Comment 1 Ryuan Choi 2012-06-10 16:44:52 PDT
Created attachment 146756 [details]
Patch
Comment 2 Gyuyoung Kim 2012-06-10 22:00:21 PDT
Comment on attachment 146756 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146756&action=review

> Source/WebKit2/CMakeLists.txt:547
> +INSTALL(TARGETS ${WebProcess_NAME}  DESTINATION bin)

Why do you install WebProcess library to *bin* directory? *bin* is directory for executable. If WebProcess is executable, it looks it is more clear to add _EXECUTABLE_ to WebProcess_NAME.
Comment 3 Ryuan Choi 2012-06-11 01:15:24 PDT
(In reply to comment #2)
> (From update of attachment 146756 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146756&action=review
> 
> > Source/WebKit2/CMakeLists.txt:547
> > +INSTALL(TARGETS ${WebProcess_NAME}  DESTINATION bin)
> 
> Why do you install WebProcess library to *bin* directory? *bin* is directory for executable. If WebProcess is executable, it looks it is more clear to add _EXECUTABLE_ to WebProcess_NAME.

Yes, WebProcess is executable.
I created bug 88767 to catch up what you mentioned.

Thank you.
Comment 4 Ryuan Choi 2012-06-11 23:23:30 PDT
Created attachment 147015 [details]
Patch
Comment 5 Gyuyoung Kim 2012-06-13 03:12:30 PDT
Comment on attachment 147015 [details]
Patch

Looks good to me now.
Comment 6 Chang Shu 2012-06-21 06:50:02 PDT
Comment on attachment 147015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147015&action=review

> Source/WebKit2/CMakeLists.txt:546
> +INSTALL(TARGETS ${WebProcess_EXECUTABLE_NAME} DESTINATION bin)

I think it's better to use a defined name such as ${EXEC_INSTALL_DIR} than a hardcoded "bin". Can you figure out where ${LIB_INSTALL_DIR} is defined?
Please take a loot at bug 71507.
Comment 7 Ryuan Choi 2012-06-21 07:45:34 PDT
Created attachment 148800 [details]
Patch
Comment 8 Ryuan Choi 2012-06-21 07:46:24 PDT
(In reply to comment #6)
> (From update of attachment 147015 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147015&action=review
> 
> > Source/WebKit2/CMakeLists.txt:546
> > +INSTALL(TARGETS ${WebProcess_EXECUTABLE_NAME} DESTINATION bin)
> 
> I think it's better to use a defined name such as ${EXEC_INSTALL_DIR} than a hardcoded "bin". Can you figure out where ${LIB_INSTALL_DIR} is defined?
> Please take a loot at bug 71507.

Thank you.

I updated like you mentioned.
Comment 9 Chang Shu 2012-06-21 07:59:22 PDT
Comment on attachment 148800 [details]
Patch

r=me.
Comment 10 WebKit Review Bot 2012-06-21 08:46:57 PDT
Comment on attachment 148800 [details]
Patch

Clearing flags on attachment: 148800

Committed r120927: <http://trac.webkit.org/changeset/120927>
Comment 11 WebKit Review Bot 2012-06-21 08:47:04 PDT
All reviewed patches have been landed.  Closing bug.