WebKit2/Efl should install public header files and .pc for separated webkit2-efl based project.
Created attachment 146756 [details] Patch
Comment on attachment 146756 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146756&action=review > Source/WebKit2/CMakeLists.txt:547 > +INSTALL(TARGETS ${WebProcess_NAME} DESTINATION bin) Why do you install WebProcess library to *bin* directory? *bin* is directory for executable. If WebProcess is executable, it looks it is more clear to add _EXECUTABLE_ to WebProcess_NAME.
(In reply to comment #2) > (From update of attachment 146756 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=146756&action=review > > > Source/WebKit2/CMakeLists.txt:547 > > +INSTALL(TARGETS ${WebProcess_NAME} DESTINATION bin) > > Why do you install WebProcess library to *bin* directory? *bin* is directory for executable. If WebProcess is executable, it looks it is more clear to add _EXECUTABLE_ to WebProcess_NAME. Yes, WebProcess is executable. I created bug 88767 to catch up what you mentioned. Thank you.
Created attachment 147015 [details] Patch
Comment on attachment 147015 [details] Patch Looks good to me now.
Comment on attachment 147015 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147015&action=review > Source/WebKit2/CMakeLists.txt:546 > +INSTALL(TARGETS ${WebProcess_EXECUTABLE_NAME} DESTINATION bin) I think it's better to use a defined name such as ${EXEC_INSTALL_DIR} than a hardcoded "bin". Can you figure out where ${LIB_INSTALL_DIR} is defined? Please take a loot at bug 71507.
Created attachment 148800 [details] Patch
(In reply to comment #6) > (From update of attachment 147015 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147015&action=review > > > Source/WebKit2/CMakeLists.txt:546 > > +INSTALL(TARGETS ${WebProcess_EXECUTABLE_NAME} DESTINATION bin) > > I think it's better to use a defined name such as ${EXEC_INSTALL_DIR} than a hardcoded "bin". Can you figure out where ${LIB_INSTALL_DIR} is defined? > Please take a loot at bug 71507. Thank you. I updated like you mentioned.
Comment on attachment 148800 [details] Patch r=me.
Comment on attachment 148800 [details] Patch Clearing flags on attachment: 148800 Committed r120927: <http://trac.webkit.org/changeset/120927>
All reviewed patches have been landed. Closing bug.