Bug 88206 - DFG arguments simplification should have rationalized handling of TearOffArguments
Summary: DFG arguments simplification should have rationalized handling of TearOffArgu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-03 19:30 PDT by Filip Pizlo
Modified: 2012-06-04 17:29 PDT (History)
0 users

See Also:


Attachments
the patch (3.96 KB, patch)
2012-06-03 19:39 PDT, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-06-03 19:30:49 PDT
Here's what should happen: the existence of TearOffArguments should have no effect on the conclusion reached by arguments simplification.  Optimally, arguments simplification should eliminate the TearOffArguments opcode in those cases where it eliminates arguments creation.  But that's not necessary for correctness.

Currently, arguments simplification completely ignores TearOffArguments because it neglects to consider accesses to the unmodified arguments register.  By some manner of dumb luck, this ends up "just working" because TearOffArguments is the only opcode that would explicitly read the unmodified arguments register.  Of course, it works in a sub-optimal way, because the TearOffArguments op ends up still being emitted.

This code should be rationalized and made to work in a sensible way.
Comment 1 Filip Pizlo 2012-06-03 19:39:36 PDT
Created attachment 145506 [details]
the patch
Comment 2 Geoffrey Garen 2012-06-03 22:29:03 PDT
Comment on attachment 145506 [details]
the patch

r=me
Comment 3 Filip Pizlo 2012-06-04 17:29:03 PDT
Landed in http://trac.webkit.org/changeset/119444