RESOLVED FIXED 88206
DFG arguments simplification should have rationalized handling of TearOffArguments 
https://bugs.webkit.org/show_bug.cgi?id=88206
Summary DFG arguments simplification should have rationalized handling of TearOffArgu...
Filip Pizlo
Reported 2012-06-03 19:30:49 PDT
Here's what should happen: the existence of TearOffArguments should have no effect on the conclusion reached by arguments simplification. Optimally, arguments simplification should eliminate the TearOffArguments opcode in those cases where it eliminates arguments creation. But that's not necessary for correctness. Currently, arguments simplification completely ignores TearOffArguments because it neglects to consider accesses to the unmodified arguments register. By some manner of dumb luck, this ends up "just working" because TearOffArguments is the only opcode that would explicitly read the unmodified arguments register. Of course, it works in a sub-optimal way, because the TearOffArguments op ends up still being emitted. This code should be rationalized and made to work in a sensible way.
Attachments
the patch (3.96 KB, patch)
2012-06-03 19:39 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-06-03 19:39:36 PDT
Created attachment 145506 [details] the patch
Geoffrey Garen
Comment 2 2012-06-03 22:29:03 PDT
Comment on attachment 145506 [details] the patch r=me
Filip Pizlo
Comment 3 2012-06-04 17:29:03 PDT
Landed in http://trac.webkit.org/changeset/119444
Note You need to log in before you can comment on or make changes to this bug.