Bug 88205 - get_argument_by_val should be profiled everywhere
Summary: get_argument_by_val should be profiled everywhere
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-03 19:27 PDT by Filip Pizlo
Modified: 2012-06-04 16:33 PDT (History)
0 users

See Also:

Attachments
the patch (1.84 KB, patch)
2012-06-03 19:40 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-06-03 19:27:06 PDT 
The JSVALUE64 JIT does it on fast and slow paths.  The 32_64 JIT does it on fast paths only.  The LLInt does it on fast paths only.

All implementations of this opcode ought to be profiled.
Comment 1 Filip Pizlo 2012-06-03 19:40:20 PDT 
Created attachment 145507 [details]
the patch
Comment 2 Geoffrey Garen 2012-06-03 22:27:41 PDT 
Comment on attachment 145507 [details]
the patch

r=me
Comment 3 Filip Pizlo 2012-06-04 16:33:19 PDT 
Landed in http://trac.webkit.org/changeset/119438