Bug 88204 – Remove SelectorQueryCacheEntry from SelectorQuery.h

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Kentaro Hara]

As anttik@ pointed out in https://bugs.webkit.org/show_bug.cgi?id=87942#c15 , we can remove SelectorQueryCacheEntry by having SelectorQuery hold CSSSelectorList.

[Kentaro Hara]

Created attachment 145501 [details]
Patch

[Hajime Morrita]

Comment on attachment 145501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145501&action=review

> Source/WebCore/dom/SelectorQuery.cpp:187
> +    SelectorQuery* selectorQueryPtr = selectorQuery.get();

Don't use abbreviations like Ptr. FooPointer or rawFoo would be nicer.

[Kentaro Hara]

Created attachment 145515 [details]
patch for landing

[Kentaro Hara]

(In reply to comment #2)
> (From update of attachment 145501 [details])
> Don't use abbreviations like Ptr. FooPointer or rawFoo would be nicer.

Fixed.

anttik: If the patch looks OK, please cq+ it.

[Antti Koivisto]

Comment on attachment 145515 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=145515&action=review

> Source/WebCore/dom/SelectorQuery.cpp:147
> +SelectorQuery::SelectorQuery(const CSSSelectorList& selectorList) : m_selectorList(selectorList)
>  {

In WebKit style an initializer goes to a line of its own (indented)

> Source/WebCore/dom/SelectorQuery.h:79
> +    // m_selectorList keeps the lifetime of CSSSelector objects in m_selectors.
> +    // Since m_selectors just holds pointers to CSSSelector objects,
> +    // m_selectorList must not be destructed before m_selectors is destructed.

This comment no longer adds value and can be removed

[Kentaro Hara]

Created attachment 145538 [details]
patch for landing

[Kentaro Hara]

(In reply to comment #5)
> > Source/WebCore/dom/SelectorQuery.cpp:147
> > +SelectorQuery::SelectorQuery(const CSSSelectorList& selectorList) : m_selectorList(selectorList)
> >  {
> 
> In WebKit style an initializer goes to a line of its own (indented)

Fixed.

> > Source/WebCore/dom/SelectorQuery.h:79
> > +    // m_selectorList keeps the lifetime of CSSSelector objects in m_selectors.
> > +    // Since m_selectors just holds pointers to CSSSelector objects,
> > +    // m_selectorList must not be destructed before m_selectors is destructed.
> 
> This comment no longer adds value and can be removed

Removed. Thanks.

[WebKit Review Bot]

Comment on attachment 145538 [details]
patch for landing

Rejecting attachment 145538 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
#1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/dom/SelectorQuery.cpp
Hunk #1 succeeded at 143 with fuzz 1.
Hunk #2 succeeded at 169 (offset 6 lines).
patching file Source/WebCore/dom/SelectorQuery.h
Hunk #1 FAILED at 67.
Hunk #2 succeeded at 102 (offset 1 line).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/dom/SelectorQuery.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12894238

[Kentaro Hara]

Created attachment 145562 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 145562 [details]
patch for landing

Rejecting attachment 145562 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

MORITA Hajime found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12894294

[Kentaro Hara]

Created attachment 145564 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 145564 [details]
patch for landing

Rejecting attachment 145564 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Morita Hajime found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12900193

[Kentaro Hara]

Created attachment 145565 [details]
patch for landing

[WebKit Review Bot]

Comment on attachment 145565 [details]
patch for landing

Clearing flags on attachment: 145565

Committed r119399: <http://trac.webkit.org/changeset/119399>