WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
88182
[WebKit2] Use USE(), ENABLE(), and HAVE() macros in more places
https://bugs.webkit.org/show_bug.cgi?id=88182
Summary
[WebKit2] Use USE(), ENABLE(), and HAVE() macros in more places
Andy Estes
Reported
2012-06-02 19:37:00 PDT
[WebKit2] Use USE(), ENABLE(), and HAVE() macros in more places
Attachments
Patch
(17.49 KB, patch)
2012-06-02 19:42 PDT
,
Andy Estes
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andy Estes
Comment 1
2012-06-02 19:42:07 PDT
Created
attachment 145471
[details]
Patch
Sam Weinig
Comment 2
2012-06-02 19:44:12 PDT
Comment on
attachment 145471
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=145471&action=review
> Source/WebKit2/Shared/mac/WebEventFactory.h:45 > +#if USE(APPKIT) > static WebMouseEvent createWebMouseEvent(NSEvent *event, NSView *windowView); > static WebWheelEvent createWebWheelEvent(NSEvent *event, NSView *windowView); > static WebKeyboardEvent createWebKeyboardEvent(NSEvent *event, NSView *windowView); > +#endif > > #if ENABLE(GESTURE_EVENTS) > static WebGestureEvent createWebGestureEvent(NSEvent *event, NSView *windowView);
It seems like the USE(APPKIT) should go all the way down to include the ENABLE(GESTURE_EVENTS).
Andy Estes
Comment 3
2012-06-02 19:46:28 PDT
Committed
r119349
: <
http://trac.webkit.org/changeset/119349
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug