Bug 88182 - [WebKit2] Use USE(), ENABLE(), and HAVE() macros in more places
Summary: [WebKit2] Use USE(), ENABLE(), and HAVE() macros in more places
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-02 19:37 PDT by Andy Estes
Modified: 2012-06-02 19:46 PDT (History)
0 users

See Also:

Attachments
Patch (17.49 KB, patch)
2012-06-02 19:42 PDT, Andy Estes 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2012-06-02 19:37:00 PDT 
[WebKit2] Use USE(), ENABLE(), and HAVE() macros in more places
Comment 1 Andy Estes 2012-06-02 19:42:07 PDT 
Created attachment 145471 [details]
Patch
Comment 2 Sam Weinig 2012-06-02 19:44:12 PDT 
Comment on attachment 145471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145471&action=review

> Source/WebKit2/Shared/mac/WebEventFactory.h:45
> +#if USE(APPKIT)
>      static WebMouseEvent createWebMouseEvent(NSEvent *event, NSView *windowView);
>      static WebWheelEvent createWebWheelEvent(NSEvent *event, NSView *windowView);
>      static WebKeyboardEvent createWebKeyboardEvent(NSEvent *event, NSView *windowView);
> +#endif
>  
>  #if ENABLE(GESTURE_EVENTS)
>      static WebGestureEvent createWebGestureEvent(NSEvent *event, NSView *windowView);

It seems like the USE(APPKIT) should go all the way down to include the ENABLE(GESTURE_EVENTS).
Comment 3 Andy Estes 2012-06-02 19:46:28 PDT 
Committed r119349: <http://trac.webkit.org/changeset/119349>