Bug 88175 - DOM string cache should hash pointers, not characters
Summary: DOM string cache should hash pointers, not characters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-02 14:05 PDT by Geoffrey Garen
Modified: 2012-06-02 20:46 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.78 KB, patch)
2012-06-02 14:28 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (7.77 KB, patch)
2012-06-02 15:28 PDT, Geoffrey Garen 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2012-06-02 14:05:51 PDT 
DOM string cache should hash pointers, not characters
Comment 1 Geoffrey Garen 2012-06-02 14:28:51 PDT 
Created attachment 145459 [details]
Patch
Comment 2 Geoffrey Garen 2012-06-02 15:28:31 PDT 
Created attachment 145461 [details]
Patch
Comment 3 Geoffrey Garen 2012-06-02 15:49:32 PDT 
Committed r119341: <http://trac.webkit.org/changeset/119341>
Comment 4 Ryosuke Niwa 2012-06-02 20:07:41 PDT 
It appears that this patch broke Windows build:

http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/49801/steps/compile-webkit/logs/stdio

7>   Creating library C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\lib\DumpRenderTree.lib and object C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\lib\DumpRenderTree.exp
7>WebCoreTestSupport.lib(JSInternals.obj) : error LNK2019: unresolved external symbol "class JSC::JSValue __cdecl WebCore::jsStringSlowCase(class JSC::ExecState *,class WTF::HashMap<class WTF::StringImpl *,class JSC::Weak<class JSC::JSString>,struct WTF::PtrHash<class WTF::StringImpl *>,struct WTF::HashTraits<class WTF::StringImpl *>,struct WTF::HashTraits<class JSC::Weak<class JSC::JSString> > > &,class WTF::StringImpl *)" (?jsStringSlowCase@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@AAV?$HashMap@PAVStringImpl@WTF@@V?$Weak@VJSString@JSC@@@JSC@@U?$PtrHash@PAVStringImpl@WTF@@@2@U?$HashTraits@PAVStringImpl@WTF@@@2@U?$HashTraits@V?$Weak@VJSString@JSC@@@JSC@@@2@@WTF@@PAVStringImpl@6@@Z) referenced in function "class JSC::JSValue __cdecl WebCore::jsString(class JSC::ExecState *,class WTF::String const &)" (?jsString@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@ABVString@WTF@@@Z)
7>C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\bin\DumpRenderTree.dll : fatal error LNK1120: 1 unresolved externals
7>Build log was saved at "file://C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\obj\DumpRenderTree\BuildLog.htm"
7>DumpRenderTree - 2 error(s), 0 warning(s)
Comment 5 Geoffrey Garen 2012-06-02 20:46:30 PDT 
WIndows build fix: <http://trac.webkit.org/changeset/119351>.