Bug 88170 - Fix a couple flexbox tests to use flex-start and flex-end
Summary: Fix a couple flexbox tests to use flex-start and flex-end
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-02 10:21 PDT by Tony Chang
Modified: 2012-06-04 10:05 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.11 KB, patch)
2012-06-02 10:23 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-06-02 10:21:37 PDT
Fix a couple flexbox tests to use flex-start and flex-end
Comment 1 Tony Chang 2012-06-02 10:23:27 PDT
Created attachment 145450 [details]
Patch
Comment 2 Ojan Vafai 2012-06-04 09:53:45 PDT
Nit: if we were to fix this to not break again, we'd add asserts to each div that they have the expected alignment in the computed style.
Comment 3 WebKit Review Bot 2012-06-04 10:05:38 PDT
Comment on attachment 145450 [details]
Patch

Clearing flags on attachment: 145450

Committed r119405: <http://trac.webkit.org/changeset/119405>
Comment 4 WebKit Review Bot 2012-06-04 10:05:42 PDT
All reviewed patches have been landed.  Closing bug.