Bug 88158 - Lots of "failed download-built-product" on Apple bots
Summary: Lots of "failed download-built-product" on Apple bots
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
Keywords: MakingBotsRed
Depends on:
Reported: 2012-06-01 18:07 PDT by Tim Horton
Modified: 2012-06-05 14:57 PDT (History)
5 users (show)

See Also:

speculative patch (4.40 KB, patch)
2012-06-01 18:09 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (5.74 KB, patch)
2012-06-05 13:21 PDT, Jon Lee
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2012-06-01 18:07:24 PDT
We're seeing "failed download-built-product" a lot. I'm not sure why, but have a hunch that it's related to buildbot's mergeRequests and Jon's out-of-order building/testing and maybe the buildbot upgrade. I'd like to try disabling mergeRequests and see if it's related. I don't think we want it anyway.
Comment 1 Tim Horton 2012-06-01 18:09:24 PDT
Created attachment 145415 [details]
speculative patch
Comment 2 WebKit Review Bot 2012-06-01 18:11:33 PDT
Attachment 145415 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-c..." exit_code: 1
Tools/BuildSlaveSupport/build.webkit.org-config/config.json:74:  Expecting object: line 74 column 40 (char 4421)  [json/syntax] [5]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jessie Berlin 2012-06-01 18:15:46 PDT
Comment on attachment 145415 [details]
speculative patch

You may want to file a bug about the style checker
Comment 4 Tim Horton 2012-06-01 18:33:30 PDT
Leaving this open after landing it in http://trac.webkit.org/changeset/119305 until we can confirm it's fixed.
Comment 5 Tim Horton 2012-06-03 19:47:38 PDT
Unsuccessful, buildbot is still merging builds: http://build.webkit.org/builders/Lion%20Release%20%28Build%29/builds/10221
Comment 6 Jon Lee 2012-06-05 12:29:54 PDT
The master buildbot got kicked this morning at around 9 am, and it's looking a lot better now.
Comment 7 Tim Horton 2012-06-05 12:37:26 PDT
If we make it through today without a) getting super backed up and b) any "failed download-built-product", we are probably OK for now. That said, we should probably look into fixing the problem properly instead of hacking around it like this, since this is going to make our queue longer for sure.
Comment 8 Jon Lee 2012-06-05 13:21:48 PDT
Created attachment 145860 [details]
Comment 9 Jon Lee 2012-06-05 13:23:32 PDT
Posting a patch that would revert building bots to their old behavior (pick oldest request, merge any later requests), and have testing, performance, and leaks bots choose the latest build.
Comment 10 Mark Rowe (bdash) 2012-06-05 13:35:05 PDT
Jon and I determined that this is due to an underlying Buildbot bug. I wrote it up as <http://trac.buildbot.net/ticket/2309>.
Comment 11 Jon Lee 2012-06-05 13:41:53 PDT
Committed r119519: <http://trac.webkit.org/changeset/119519>
Comment 12 Jon Lee 2012-06-05 13:42:44 PDT
Reopening, to monitor the bots for a while with this change.