REOPENED 88158
Lots of "failed download-built-product" on Apple bots 
https://bugs.webkit.org/show_bug.cgi?id=88158
Summary Lots of "failed download-built-product" on Apple bots
Tim Horton
Reported 2012-06-01 18:07:24 PDT
We're seeing "failed download-built-product" a lot. I'm not sure why, but have a hunch that it's related to buildbot's mergeRequests and Jon's out-of-order building/testing and maybe the buildbot upgrade. I'd like to try disabling mergeRequests and see if it's related. I don't think we want it anyway.
Attachments
speculative patch (4.40 KB, patch)
2012-06-01 18:09 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (5.74 KB, patch)
2012-06-05 13:21 PDT, Jon Lee 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2012-06-01 18:09:24 PDT
Created attachment 145415 [details] speculative patch
WebKit Review Bot
Comment 2 2012-06-01 18:11:33 PDT
Attachment 145415 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-c..." exit_code: 1 Tools/BuildSlaveSupport/build.webkit.org-config/config.json:74: Expecting object: line 74 column 40 (char 4421) [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jessie Berlin
Comment 3 2012-06-01 18:15:46 PDT
Comment on attachment 145415 [details] speculative patch You may want to file a bug about the style checker
Tim Horton
Comment 4 2012-06-01 18:33:30 PDT
Leaving this open after landing it in http://trac.webkit.org/changeset/119305 until we can confirm it's fixed.
Tim Horton
Comment 5 2012-06-03 19:47:38 PDT
Unsuccessful, buildbot is still merging builds: http://build.webkit.org/builders/Lion%20Release%20%28Build%29/builds/10221
Jon Lee
Comment 6 2012-06-05 12:29:54 PDT
The master buildbot got kicked this morning at around 9 am, and it's looking a lot better now.
Tim Horton
Comment 7 2012-06-05 12:37:26 PDT
If we make it through today without a) getting super backed up and b) any "failed download-built-product", we are probably OK for now. That said, we should probably look into fixing the problem properly instead of hacking around it like this, since this is going to make our queue longer for sure.
Jon Lee
Comment 8 2012-06-05 13:21:48 PDT
Created attachment 145860 [details] Patch
Jon Lee
Comment 9 2012-06-05 13:23:32 PDT
Posting a patch that would revert building bots to their old behavior (pick oldest request, merge any later requests), and have testing, performance, and leaks bots choose the latest build.
Mark Rowe (bdash)
Comment 10 2012-06-05 13:35:05 PDT
Jon and I determined that this is due to an underlying Buildbot bug. I wrote it up as <http://trac.buildbot.net/ticket/2309>.
Jon Lee
Comment 11 2012-06-05 13:41:53 PDT
Committed r119519: <http://trac.webkit.org/changeset/119519>
Jon Lee
Comment 12 2012-06-05 13:42:44 PDT
Reopening, to monitor the bots for a while with this change.
Note You need to log in before you can comment on or make changes to this bug.