Bug 88141 - DFG constant folding search for the last local access skips the immediately previous local access
Summary: DFG constant folding search for the last local access skips the immediately p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-01 15:24 PDT by Filip Pizlo
Modified: 2012-06-01 15:45 PDT (History)
0 users

See Also:

Attachments
the patch (4.49 KB, patch)
2012-06-01 15:26 PDT, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-06-01 15:24:19 PDT 
If you use a loop in the style of:

for (i = start; i--;)

then you need to remember that the first value of 'i' that the loop body will see is 'start - 1'.  Hence the following is probably wrong:

for (i = start - 1; i--;)
Comment 1 Filip Pizlo 2012-06-01 15:26:43 PDT 
Created attachment 145390 [details]
the patch
Comment 2 Filip Pizlo 2012-06-01 15:45:10 PDT 
Landed in http://trac.webkit.org/changeset/119292