Bug 88138 - [Gtk][EFL] http/tests/media/video-buffered.html is failing after r119268
Summary: [Gtk][EFL] http/tests/media/video-buffered.html is failing after r119268
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ami Fischman
URL:
Keywords: LayoutTestFailure, MakingBotsRed
Depends on:
Blocks:
 
Reported: 2012-06-01 14:50 PDT by Zan Dobersek
Modified: 2012-06-04 12:27 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.28 KB, patch)
2012-06-01 15:01 PDT, Ami Fischman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-06-01 14:50:43 PDT
http/tests/media/video-buffered.html started failing after r119268[1].

Here's the diff:

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/http/tests/media/video-buffered-expected.txt 
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/http/tests/media/video-buffered-actual.txt 
@@ -1,9 +1,616 @@
+FAIL: Timed out waiting for notifyDone to be called
 Start playing a video with preloading enabled, do a seek near the end and check multiple buffered timeranges have been created.
 
 EVENT(playing)
 EXPECTED (video.buffered.length == '1') OK
 RUN(video.currentTime = video.duration - 0.5)
-EVENT(ended)
-EXPECTED (video.buffered.length == '2') OK
-END OF TEST
+EVENT(playing)
+EXPECTED (video.buffered.length == '1') OK
+RUN(video.currentTime = video.duration - 0.5)
+EVENT(playing)
+EXPECTED (video.buffered.length == '1') OK
+RUN(video.currentTime = video.duration - 0.5)
+EVENT(playing)
+EXPECTED (video.buffered.length == '1') OK
+RUN(video.currentTime = video.duration - 0.5)
.
.
.
(continues until timing out)

[1] - http://trac.webkit.org/changeset/119268/
Comment 1 Ami Fischman 2012-06-01 15:01:29 PDT
Created attachment 145384 [details]
Patch
Comment 2 Ami Fischman 2012-06-01 15:03:22 PDT
Oops, sorry for the noise.
zandobersek: can you verify the patch fixes things for you?
Comment 3 Ami Fischman 2012-06-01 15:43:04 PDT
zandobersek@: BTW, any idea why the GTK EWS didn't catch the problem on 87568?

eric.carlson: i can haz r+?
Comment 4 Philippe Normand 2012-06-01 15:47:36 PDT
GTK EWS doesn't run the layout tests yet. Only Chromium's does, AFAIK.
Comment 5 Chris Dumez 2012-06-03 10:48:22 PDT
Test has been skipped for EFL port in Bug 88194, while waiting for the fix to land.
Comment 6 WebKit Review Bot 2012-06-04 12:27:15 PDT
Comment on attachment 145384 [details]
Patch

Clearing flags on attachment: 145384

Committed r119415: <http://trac.webkit.org/changeset/119415>
Comment 7 WebKit Review Bot 2012-06-04 12:27:27 PDT
All reviewed patches have been landed.  Closing bug.