Bug 88137 - DFG constant folding should be OK with GetLocal of captured variables having a constant
Summary: DFG constant folding should be OK with GetLocal of captured variables having ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-01 14:27 PDT by Filip Pizlo
Modified: 2012-06-01 15:18 PDT (History)
2 users (show)

See Also:

Attachments
the patch (10.94 KB, patch)
2012-06-01 14:28 PDT, Filip Pizlo 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-06-01 14:27:30 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2012-06-01 14:28:35 PDT 
Created attachment 145376 [details]
the patch
Comment 2 Geoffrey Garen 2012-06-01 14:32:41 PDT 
r=me

> LayoutTests/fast/js/dfg-cse-cfa-discrepancy-expected.txt:1
> +Tests stability when the CFA finds a constant in block-local data flow over captured variables but the CSE doesn't because if differences in heap modeling.

Typo: "if" should be "of".
Comment 3 Filip Pizlo 2012-06-01 14:33:48 PDT 
Landed in http://trac.webkit.org/changeset/119281, but before I saw Gavin's comment.  Fix for that on the way.
Comment 4 Filip Pizlo 2012-06-01 14:34:58 PDT 
Typo fix in http://trac.webkit.org/changeset/119282
Comment 5 Ryosuke Niwa 2012-06-01 15:16:33 PDT 
(In reply to comment #4)
> Typo fix in http://trac.webkit.org/changeset/119282

And did the same in the expected result: http://trac.webkit.org/changeset/119288
Comment 6 Filip Pizlo 2012-06-01 15:18:31 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > Typo fix in http://trac.webkit.org/changeset/119282
> 
> And did the same in the expected result: http://trac.webkit.org/changeset/119288

Ooops!  Thank you for fixing this!